Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1599)

Issue 1755603002: CREDENTIAL: Do type checks for credential constructors. (Closed)

Created:
4 years, 9 months ago by Mike West
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

CREDENTIAL: Do type checks for credential constructors. BUG=590610 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1745963002 Cr-Commit-Position: refs/heads/master@{#378194} (cherry picked from commit 80aa06df6c68611a18eff99fc6a048d6843b9ea6) Committed: https://chromium.googlesource.com/chromium/src/+/ea796daa7f532ada0d514de9652bf78fccef99f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/credentialmanager/federatedcredential-basics.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html View 1 chunk +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Mike West
4 years, 9 months ago (2016-03-01 12:58:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ea796daa7f532ada0d514de9652bf78fccef99f2.

Powered by Google App Engine
This is Rietveld 408576698