Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 1755563002: [interpreter] Properly collect for-in slow mode feedback. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Properly collect for-in slow mode feedback. Similar to fullcodegen, Ignition now also marks a for-in statement as slow (via the TypeFeedbackVector) when we have to call %ForInFilter, i.e. we either have no enumeration cache or the receiver map changes during an iteration of the for-in map. R=mstarzinger@chromium.org BUG=v8:3650 LOG=n Committed: https://crrev.com/0cb8a1b774b8a4e181c6dba355f9d6b73fb374f3 Cr-Commit-Position: refs/heads/master@{#34391}

Patch Set 1 #

Patch Set 2 : Recementation #

Patch Set 3 : More recementation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -61 lines) Patch
M src/compiler/code-stub-assembler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +10 lines, -6 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +32 lines, -5 lines 0 comments Download
M src/type-feedback-vector.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/type-feedback-vector-inl.h View 1 chunk +4 lines, -8 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/ForIn.golden View 1 8 chunks +24 lines, -24 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/WideRegisters.golden View 1 4 chunks +6 lines, -6 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/interpreter/register-translator-unittest.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-01 10:37:55 UTC) #1
Benedikt Meurer
Hey Michi, Syncing fullcodegen and Ignition. Please take a look. Thanks, Benedikt
4 years, 9 months ago (2016-03-01 10:39:02 UTC) #2
Michael Starzinger
LGTM.
4 years, 9 months ago (2016-03-01 13:25:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755563002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755563002/40001
4 years, 9 months ago (2016-03-01 13:38:50 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-01 13:55:52 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 13:56:12 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0cb8a1b774b8a4e181c6dba355f9d6b73fb374f3
Cr-Commit-Position: refs/heads/master@{#34391}

Powered by Google App Engine
This is Rietveld 408576698