Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: src/interpreter/bytecode-array-builder.cc

Issue 1755563002: [interpreter] Properly collect for-in slow mode feedback. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: More recementation Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.h ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/bytecode-array-builder.cc
diff --git a/src/interpreter/bytecode-array-builder.cc b/src/interpreter/bytecode-array-builder.cc
index 5bdf4ab24ba097ed5b017a661e2869a5d055c1df..18df5ec5fc2db4995afadb37e124b0efb1e1b565 100644
--- a/src/interpreter/bytecode-array-builder.cc
+++ b/src/interpreter/bytecode-array-builder.cc
@@ -991,17 +991,21 @@ BytecodeArrayBuilder& BytecodeArrayBuilder::ForInDone(Register index,
return *this;
}
-
BytecodeArrayBuilder& BytecodeArrayBuilder::ForInNext(
- Register receiver, Register index, Register cache_type_array_pair) {
+ Register receiver, Register index, Register cache_type_array_pair,
+ int feedback_slot) {
if (FitsInReg8Operand(receiver) && FitsInReg8Operand(index) &&
- FitsInReg8Operand(cache_type_array_pair)) {
+ FitsInReg8Operand(cache_type_array_pair) &&
+ FitsInIdx8Operand(feedback_slot)) {
Output(Bytecode::kForInNext, receiver.ToRawOperand(), index.ToRawOperand(),
- cache_type_array_pair.ToRawOperand());
+ cache_type_array_pair.ToRawOperand(),
+ static_cast<uint8_t>(feedback_slot));
} else if (FitsInReg16Operand(receiver) && FitsInReg16Operand(index) &&
- FitsInReg16Operand(cache_type_array_pair)) {
+ FitsInReg16Operand(cache_type_array_pair) &&
+ FitsInIdx16Operand(feedback_slot)) {
Output(Bytecode::kForInNextWide, receiver.ToRawOperand(),
- index.ToRawOperand(), cache_type_array_pair.ToRawOperand());
+ index.ToRawOperand(), cache_type_array_pair.ToRawOperand(),
+ static_cast<uint16_t>(feedback_slot));
} else {
UNIMPLEMENTED();
}
« no previous file with comments | « src/interpreter/bytecode-array-builder.h ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698