Fix SubtreeLayoutScope not to schedule relayout

Fix SubtreeLayoutScope not to schedule relayout

This patch fixes SubtreeLayoutScope::setNeedsLayout() and
setChildNeedsLayout() not to schedule relayout when they call
markContainerChainForLayout().

The signature of markContainerChainForLayout() allows to schedule
relayout even when SubtreeLayoutScope exists. To not allow scheduling
relayout while we're in layout, this patch changes the signature.

BUG=590620
Committed: https://crrev.com/6e396c50a4630c1bd065aaf19244cf8c1fdcd6d1
Cr-Commit-Position: refs/heads/master@{#378639}

[kojii, 2016-03-01 15:49:23]

Description was changed from

==========
WIP: f-markContainerChainForLayout

BUG=
==========

to

==========
Fix SubtreeLayoutScope not to schedule relayout

This patch fixes SubtreeLayoutScope::setNeedsLayout() and
setChildNeedsLayout() not to schedule relayout when they call
markContainerChainForLayout().

The signature of markContainerChainForLayout() allows to schedule
relayout even when SubtreeLayoutScope exists. To not allow scheduling
relayout while we're in layout, this patch changes the signature.

BUG=590620
==========

[kojii, 2016-03-01 15:51:41]

kojii@chromium.org changed reviewers:
+ leviw@chromium.org

[kojii, 2016-03-01 15:51:42]

PTAL.

Thank you for the advice on the bug, I hope I understand this correctly. Please
tell me if the change does not look sane, I haven't played with code around this
much yet.

Wanted to write shorter/simpler test but the criteria for this to happen is so
low that I ended up not-so-simple test...

[leviw_travelin_and_unemployed, 2016-03-01 23:54:42]

leviw@chromium.org changed reviewers:
+ cbiesinger@chromium.org

[leviw_travelin_and_unemployed, 2016-03-01 23:54:43]

cbiesinger ran into this issue as well.

[leviw_travelin_and_unemployed, 2016-03-01 23:56:21]

I think this is perfect! LGTM!

[kojii, 2016-03-02 00:56:48]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-03-02 00:57:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755543002/20001

[commit-bot: I haz the power, 2016-03-02 01:05:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-02 01:06:13]

Description was changed from

==========
Fix SubtreeLayoutScope not to schedule relayout

This patch fixes SubtreeLayoutScope::setNeedsLayout() and
setChildNeedsLayout() not to schedule relayout when they call
markContainerChainForLayout().

The signature of markContainerChainForLayout() allows to schedule
relayout even when SubtreeLayoutScope exists. To not allow scheduling
relayout while we're in layout, this patch changes the signature.

BUG=590620
==========

to

==========
Fix SubtreeLayoutScope not to schedule relayout

This patch fixes SubtreeLayoutScope::setNeedsLayout() and
setChildNeedsLayout() not to schedule relayout when they call
markContainerChainForLayout().

The signature of markContainerChainForLayout() allows to schedule
relayout even when SubtreeLayoutScope exists. To not allow scheduling
relayout while we're in layout, this patch changes the signature.

BUG=590620

Committed: https://crrev.com/6e396c50a4630c1bd065aaf19244cf8c1fdcd6d1
Cr-Commit-Position: refs/heads/master@{#378639}
==========

[commit-bot: I haz the power, 2016-03-02 01:06:14]

Patchset 2 (id:??) landed as
https://crrev.com/6e396c50a4630c1bd065aaf19244cf8c1fdcd6d1
Cr-Commit-Position: refs/heads/master@{#378639}

[cbiesinger, 2016-03-02 01:40:00]

Thanks! Much better than what I'd have done.