Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 175543004: Revert of Enable the SSSE3 files to be built for Android when SSSE3 is not present. (Closed)

Created:
6 years, 10 months ago by scroggo
Modified:
6 years, 10 months ago
Reviewers:
mtklein, djsollen, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Enable the SSSE3 files to be built for Android when SSSE3 is not present. (https://codereview.chromium.org/169753004/) Reason for revert: Breaking the build. Non-android machines are calling sk_throw(). Original issue's description: > Enable the SSSE3 files to be built for Android when SSSE3 is not present. > > Committed: http://code.google.com/p/skia/source/detail?r=13547 TBR=reed@google.com,mtklein@google.com,djsollen@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13549

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -31 lines) Patch
M include/core/SkPreConfig.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSSE3.cpp View 2 chunks +1 line, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Created Revert of Enable the SSSE3 files to be built for Android when SSSE3 is ...
6 years, 10 months ago (2014-02-21 23:11:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/175543004/1
6 years, 10 months ago (2014-02-21 23:11:29 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 23:11:38 UTC) #3
Message was sent while issue was closed.
Change committed as 13549

Powered by Google App Engine
This is Rietveld 408576698