Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1755423003: Re-use PromiseResolver helper in print preview. (Closed)

Created:
4 years, 9 months ago by dpapad
Modified:
4 years, 9 months ago
Reviewers:
Dan Beam, tbarzic
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@reject_promise
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-use PromiseResolver helper in print preview. TBR=tbarzic@chromium.org Committed: https://crrev.com/0db8c1a80c76832140adfc7c2171fbd6f9067713 Cr-Commit-Position: refs/heads/master@{#379446}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Templatizing #

Total comments: 2

Patch Set 3 : Add @struct #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -41 lines) Patch
M chrome/browser/resources/print_preview/print_preview.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/search/provisional_destination_resolver.js View 1 3 chunks +2 lines, -37 lines 0 comments Download
M ui/webui/resources/js/promise_resolver.js View 1 2 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Dan Beam
https://codereview.chromium.org/1755423003/diff/1/chrome/browser/resources/print_preview/search/provisional_destination_resolver.js File chrome/browser/resources/print_preview/search/provisional_destination_resolver.js (left): https://codereview.chromium.org/1755423003/diff/1/chrome/browser/resources/print_preview/search/provisional_destination_resolver.js#oldcode26 chrome/browser/resources/print_preview/search/provisional_destination_resolver.js:26: function PromiseResolver(promise, resolve, reject) { nit: perhaps we should ...
4 years, 9 months ago (2016-03-03 21:18:24 UTC) #2
dpapad
@tbarzic: You had added this code at https://codereview.chromium.org/1144983002. I don't know how to trigger this ...
4 years, 9 months ago (2016-03-04 18:58:43 UTC) #5
Dan Beam
lgtm https://codereview.chromium.org/1755423003/diff/20001/ui/webui/resources/js/promise_resolver.js File ui/webui/resources/js/promise_resolver.js (right): https://codereview.chromium.org/1755423003/diff/20001/ui/webui/resources/js/promise_resolver.js#newcode28 ui/webui/resources/js/promise_resolver.js:28: this.reject; maybe you already mentioned this (as I ...
4 years, 9 months ago (2016-03-04 19:29:26 UTC) #7
Dan Beam
++code health!
4 years, 9 months ago (2016-03-04 19:29:43 UTC) #8
dpapad
https://codereview.chromium.org/1755423003/diff/20001/ui/webui/resources/js/promise_resolver.js File ui/webui/resources/js/promise_resolver.js (right): https://codereview.chromium.org/1755423003/diff/20001/ui/webui/resources/js/promise_resolver.js#newcode28 ui/webui/resources/js/promise_resolver.js:28: this.reject; On 2016/03/04 at 19:29:26, Dan Beam wrote: > ...
4 years, 9 months ago (2016-03-04 20:01:28 UTC) #9
Dan Beam
still lgtm, thx for explanation
4 years, 9 months ago (2016-03-04 20:30:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755423003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755423003/40001
4 years, 9 months ago (2016-03-05 00:59:59 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-05 02:55:12 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-05 02:56:15 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0db8c1a80c76832140adfc7c2171fbd6f9067713
Cr-Commit-Position: refs/heads/master@{#379446}

Powered by Google App Engine
This is Rietveld 408576698