Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 1144983002: Introduce concept of provisional destinations to print preview (Closed)

Created:
5 years, 7 months ago by tbarzic
Modified:
5 years, 6 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce concept of provisional destination to print preview These are destinations that can be listed in the UI, but cannot be set as a selected destination in destination store. When user selects them in destination search UI, extra steps are taken in order to resolve these destinations. When resolved, provisional destinations are replaced by the resolved version, which is then selected. This is used for selecting USB printers that can be handled by an extension destination provider (as decleared in the extension manifest), but for whose USB devices the extension does not yet have permission. These destinations cannot be directly handled by the extension, as it is not avare of their presence. These destinations are provided by printer provider API backend. When attempting to select those, user is asked to allow the extension to access the USB device in question. If the user agrees, the extension is given permission to access the USB device and requested printer description for the USB printer. When the printer description is returned, the provisional destinaion is removed from destination store. The new destination is added to the store and selected. BUG=468955 Committed: https://crrev.com/fd8d83b5e6fec748d71a6dff7ead345ca89d784e Cr-Commit-Position: refs/heads/master@{#333888}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : . #

Patch Set 5 : rebase #

Total comments: 4

Patch Set 6 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+600 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 4 5 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/data/destination.js View 1 2 3 4 4 chunks +50 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/data/destination_store.js View 1 2 3 4 5 5 chunks +70 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/data/local_parsers.js View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 1 2 3 4 5 chunks +56 lines, -1 line 0 comments Download
M chrome/browser/resources/print_preview/print_preview.html View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/print_preview_focus_manager.js View 1 2 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/search/destination_search.css View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/search/destination_search.js View 1 2 3 4 5 4 chunks +72 lines, -3 lines 0 comments Download
A chrome/browser/resources/print_preview/search/provisional_destination_resolver.css View 1 2 3 4 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/search/provisional_destination_resolver.html View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/search/provisional_destination_resolver.js View 1 2 3 4 1 chunk +252 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui.cc View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
tbarzic
Built on top of https://codereview.chromium.org/1148383002/#ps20001 This is not quite ready for detailed review (for one ...
5 years, 7 months ago (2015-05-27 17:10:11 UTC) #2
Vitaly Buka (NO REVIEWS)
Does this need rebase?
5 years, 6 months ago (2015-06-01 17:29:17 UTC) #3
tbarzic
On 2015/06/01 17:29:17, Vitaly Buka wrote: > Does this need rebase? yes, it does. I'll ...
5 years, 6 months ago (2015-06-02 17:03:27 UTC) #4
tbarzic
I think this should be ready for review now. Please take a look.
5 years, 6 months ago (2015-06-04 20:57:06 UTC) #5
Aleksey Shlyapnikov
lgtm https://codereview.chromium.org/1144983002/diff/80001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/1144983002/diff/80001/chrome/browser/resources/print_preview/data/destination_store.js#newcode666 chrome/browser/resources/print_preview/data/destination_store.js:666: this.destinationMap_[this.getKey_(provisionalDestination)] = undefined; delete this.destinationMap_[this.getKey_(provisionalDestination)]; https://codereview.chromium.org/1144983002/diff/80001/chrome/browser/resources/print_preview/search/destination_search.js File chrome/browser/resources/print_preview/search/destination_search.js ...
5 years, 6 months ago (2015-06-08 23:00:54 UTC) #6
tbarzic
https://codereview.chromium.org/1144983002/diff/80001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/1144983002/diff/80001/chrome/browser/resources/print_preview/data/destination_store.js#newcode666 chrome/browser/resources/print_preview/data/destination_store.js:666: this.destinationMap_[this.getKey_(provisionalDestination)] = undefined; On 2015/06/08 23:00:54, Aleksey Shlyapnikov wrote: ...
5 years, 6 months ago (2015-06-09 18:21:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144983002/100001
5 years, 6 months ago (2015-06-11 00:54:18 UTC) #10
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 6 months ago (2015-06-11 03:53:38 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 03:54:42 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/fd8d83b5e6fec748d71a6dff7ead345ca89d784e
Cr-Commit-Position: refs/heads/master@{#333888}

Powered by Google App Engine
This is Rietveld 408576698