Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1755363003: Revert of Mustash: Move GURL ParamTraits to url/ipc (Closed)

Created:
4 years, 9 months ago by Dmitry Titov
Modified:
4 years, 9 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, mlamouri+watch-content_chromium.org, tzik, nasko+codewatch_chromium.org, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mustash: Move GURL ParamTraits to url/ipc (patchset #18 id:330001 of https://codereview.chromium.org/1722773002/ ) Reason for revert: Broke compile on iOS_Simulator_GN_(dbg): https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_GN_%28dbg%29/builds/1777 Original issue's description: > Move GURL ParamTraits to url/ipc > > As a part of the GPU refactor for Mus, we are trying to eliminate spots where content/common/gpu depends on > content/. One such dependency is GURL. As per discussion here: > https://codereview.chromium.org/1703163002/, the plan of record is to move > GURL ParamTraits out of content/ and into url/. > > BUG=586368 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/45eb2e749a8b08988ab45bfd6806c004e9f511fa > Cr-Commit-Position: refs/heads/master@{#378859} TBR=fsamuel@chromium.org,piman@chromium.org,brettw@chromium.org,tsepez@chromium.org,thakis@chromium.org,markdittmer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=586368 Committed: https://crrev.com/08ebff81c084613192bd3e0b79613e394ffb2aa7 Cr-Commit-Position: refs/heads/master@{#378869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -351 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M android_webview/android_webview.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_common.gypi View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/common/common_message_generator.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/common_message_generator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/importer/profile_import_process_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/prerender_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/autofill.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/content/common/content_settings_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/common/nacl_host_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/loader/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/network_hints.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M components/network_hints/common/network_hints_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M components/network_hints/renderer/renderer_dns_prefetch.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M components/password_manager/content/common/credential_manager_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M components/pdf.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/pdf/common/pdf_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_json/safe_json_parser_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/translate.gypi View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/content/common/translate_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/child/plugin_messages.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/child/service_worker/service_worker_dispatcher.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/accessibility_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/appcache_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/browser_plugin/browser_plugin_messages.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/clipboard_messages.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/common/common_param_traits_unittest.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M content/common/devtools_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/dom_storage/dom_storage_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/drag_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/fileapi/webblob_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/gpu_host_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/input_messages.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_shell.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/common_param_traits.h View 2 chunks +11 lines, -1 line 0 comments Download
M content/public/common/common_param_traits.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M content/public/common/content_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/shell/common/layout_test/layout_test_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_utility_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/extensions.gyp View 2 chunks +0 lines, -5 lines 0 comments Download
M extensions/utility/unpacker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M url/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D url/ipc/BUILD.gn View 1 chunk +0 lines, -38 lines 0 comments Download
D url/ipc/url_ipc.gyp View 1 chunk +0 lines, -45 lines 0 comments Download
D url/ipc/url_ipc_export.h View 1 chunk +0 lines, -29 lines 0 comments Download
D url/ipc/url_param_traits.h View 1 chunk +0 lines, -30 lines 0 comments Download
D url/ipc/url_param_traits.cc View 1 chunk +0 lines, -52 lines 0 comments Download
D url/ipc/url_param_traits_unittest.cc View 1 chunk +0 lines, -72 lines 0 comments Download
M url/url_constants.h View 2 chunks +0 lines, -4 lines 0 comments Download
M url/url_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dmitry Titov
Created Revert of Mustash: Move GURL ParamTraits to url/ipc
4 years, 9 months ago (2016-03-02 23:13:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755363003/1
4 years, 9 months ago (2016-03-02 23:14:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 23:15:45 UTC) #3
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 23:17:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08ebff81c084613192bd3e0b79613e394ffb2aa7
Cr-Commit-Position: refs/heads/master@{#378869}

Powered by Google App Engine
This is Rietveld 408576698