Index: content/common/common_param_traits_unittest.cc |
diff --git a/content/common/common_param_traits_unittest.cc b/content/common/common_param_traits_unittest.cc |
index 648e6a6e718e03bddb2d42303a531bdb4fec51b6..03c19a0873182948f67cafa908e90540d607611d 100644 |
--- a/content/common/common_param_traits_unittest.cc |
+++ b/content/common/common_param_traits_unittest.cc |
@@ -20,6 +20,68 @@ |
#include "third_party/skia/include/core/SkBitmap.h" |
#include "ui/gfx/geometry/rect.h" |
#include "ui/gfx/ipc/gfx_param_traits.h" |
+#include "url/gurl.h" |
+ |
+// Tests that serialize/deserialize correctly understand each other |
+TEST(IPCMessageTest, Serialize) { |
+ const char* serialize_cases[] = { |
+ "http://www.google.com/", |
+ "http://user:pass@host.com:888/foo;bar?baz#nop", |
+ }; |
+ |
+ for (size_t i = 0; i < arraysize(serialize_cases); i++) { |
+ GURL input(serialize_cases[i]); |
+ IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); |
+ IPC::ParamTraits<GURL>::Write(&msg, input); |
+ |
+ GURL output; |
+ base::PickleIterator iter(msg); |
+ EXPECT_TRUE(IPC::ParamTraits<GURL>::Read(&msg, &iter, &output)); |
+ |
+ // We want to test each component individually to make sure its range was |
+ // correctly serialized and deserialized, not just the spec. |
+ EXPECT_EQ(input.possibly_invalid_spec(), output.possibly_invalid_spec()); |
+ EXPECT_EQ(input.is_valid(), output.is_valid()); |
+ EXPECT_EQ(input.scheme(), output.scheme()); |
+ EXPECT_EQ(input.username(), output.username()); |
+ EXPECT_EQ(input.password(), output.password()); |
+ EXPECT_EQ(input.host(), output.host()); |
+ EXPECT_EQ(input.port(), output.port()); |
+ EXPECT_EQ(input.path(), output.path()); |
+ EXPECT_EQ(input.query(), output.query()); |
+ EXPECT_EQ(input.ref(), output.ref()); |
+ } |
+ |
+ // Test an excessively long GURL. |
+ { |
+ const std::string url = std::string("http://example.org/").append( |
+ content::kMaxURLChars + 1, 'a'); |
+ GURL input(url.c_str()); |
+ IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); |
+ IPC::ParamTraits<GURL>::Write(&msg, input); |
+ |
+ GURL output; |
+ base::PickleIterator iter(msg); |
+ EXPECT_TRUE(IPC::ParamTraits<GURL>::Read(&msg, &iter, &output)); |
+ EXPECT_TRUE(output.is_empty()); |
+ } |
+ |
+ // Test an invalid GURL. |
+ { |
+ IPC::Message msg; |
+ msg.WriteString("#inva://idurl/"); |
+ GURL output; |
+ base::PickleIterator iter(msg); |
+ EXPECT_FALSE(IPC::ParamTraits<GURL>::Read(&msg, &iter, &output)); |
+ } |
+ |
+ // Also test the corrupt case. |
+ IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); |
+ msg.WriteInt(99); |
+ GURL output; |
+ base::PickleIterator iter(msg); |
+ EXPECT_FALSE(IPC::ParamTraits<GURL>::Read(&msg, &iter, &output)); |
+} |
// Tests std::pair serialization |
TEST(IPCMessageTest, Pair) { |