Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 17553004: Fix zone usage within LAllocator. (Closed)

Created:
7 years, 6 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
danno
CC:
v8-dev
Base URL:
git@github.com:v8/v8.git@master
Visibility:
Public.

Description

Fix zone usage within LAllocator. Previously all allocations in the register allocator were done on the chunk (and graph) zone, even those that did not need to survive past the register allocation. Now only allocations that need to survive use the chunk zone, all other allocations use a separate zone local to the LAllocator. Depends on https://codereview.chromium.org/18022002 R=danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15372

Patch Set 1 #

Patch Set 2 : Rebased on https://codereview.chromium.org/18022002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -74 lines) Patch
M src/lithium-allocator.h View 1 4 chunks +5 lines, -7 lines 0 comments Download
M src/lithium-allocator.cc View 1 39 chunks +95 lines, -64 lines 0 comments Download
M src/lithium-allocator-inl.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Benedikt Meurer (Google)
7 years, 6 months ago (2013-06-21 13:18:46 UTC) #1
Benedikt Meurer (Google)
7 years, 6 months ago (2013-06-21 13:18:59 UTC) #2
danno
Shouldn't you make this an LPhase before going through all the trouble of converting the ...
7 years, 5 months ago (2013-06-27 13:42:22 UTC) #3
Benedikt Meurer
On 2013/06/27 13:42:22, danno wrote: > Shouldn't you make this an LPhase before going through ...
7 years, 5 months ago (2013-06-27 19:55:12 UTC) #4
Benedikt Meurer
7 years, 5 months ago (2013-06-27 19:56:49 UTC) #5
danno
Looking at this again, it seems just fine. I think I missed where the zones ...
7 years, 5 months ago (2013-06-27 20:57:49 UTC) #6
Benedikt Meurer
7 years, 5 months ago (2013-06-28 07:37:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r15372 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698