Issue 18022002: Move phase_zone from CompilationInfo to CompilationPhase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18022002: Move phase_zone from CompilationInfo to CompilationPhase. (Closed)

Created:
7 years, 6 months ago by Benedikt Meurer

Modified:
7 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Move phase_zone from CompilationInfo to CompilationPhase. Each CompilationPhase has its own zone, used for phase local allocations. The zone of CompilationInfo should only be used for non phase local allocations. R=danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15352

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -59 lines)			Patch
M	src/compiler.h	View	8 chunks	+19 lines, -31 lines	0 comments	Download
M	src/compiler.cc	View	4 chunks	+15 lines, -22 lines	0 comments	Download
M	src/hydrogen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/hydrogen.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/lithium.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/lithium-allocator.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

7 years, 5 months ago (2013-06-27 13:03:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15352 (presubmit successful).

Expand Messages | Collapse Messages