Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2828)

Unified Diff: remoting/protocol/negotiating_authenticator_base.h

Issue 1755273003: Simplify AuthenticationMethod type and PIN hash handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/negotiating_authenticator_base.h
diff --git a/remoting/protocol/negotiating_authenticator_base.h b/remoting/protocol/negotiating_authenticator_base.h
index 72481e3d5ee0ce202a11038b1300d345c4bc8de2..4d67a808964ce32ba2faf9ce869ec1fc61b8f376 100644
--- a/remoting/protocol/negotiating_authenticator_base.h
+++ b/remoting/protocol/negotiating_authenticator_base.h
@@ -85,7 +85,7 @@ class NegotiatingAuthenticatorBase : public Authenticator {
explicit NegotiatingAuthenticatorBase(Authenticator::State initial_state);
- void AddMethod(const AuthenticationMethod& method);
+ void AddMethod(AuthenticationMethod method);
// Updates |state_| to reflect the current underlying authenticator state.
// |resume_callback| is called after the state is updated.
@@ -96,10 +96,10 @@ class NegotiatingAuthenticatorBase : public Authenticator {
virtual scoped_ptr<buzz::XmlElement> GetNextMessageInternal();
std::vector<AuthenticationMethod> methods_;
- AuthenticationMethod current_method_;
+ AuthenticationMethod current_method_ = AuthenticationMethod::INVALID;
scoped_ptr<Authenticator> current_authenticator_;
State state_;
- RejectionReason rejection_reason_;
+ RejectionReason rejection_reason_ = INVALID_CREDENTIALS;
private:
DISALLOW_COPY_AND_ASSIGN(NegotiatingAuthenticatorBase);

Powered by Google App Engine
This is Rietveld 408576698