Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1755243002:
Partly revert of Conditionally create PaintLayer's scrollable area object (Closed)
|
Created:
4 years, 9 months ago by Xianzhu Modified:
4 years, 9 months ago Reviewers:
chrishtr CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@PaintLayerClipper Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPartly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ )
Reason for revert:
Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect
scrollableArea of a layer to disappear.
Revert functional changes, but keep refactories.
BUG=591045
Original issue's description:
> Conditionally create PaintLayer's scrollable area object
>
> BUG=467721
>
> Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e
> Cr-Commit-Position: refs/heads/master@{#378247}
TBR=chrishtr@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=467721
Committed: https://crrev.com/b772a3d31c12361e22a8d6950cbef821ac3dc7d5
Cr-Commit-Position: refs/heads/master@{#378845}
Patch Set 1 #Patch Set 2 : Partly revert #
Messages
Total messages: 25 (15 generated)
Created Revert of Conditionally create PaintLayer's scrollable area object
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755243002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
Description was changed from ========== Revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ========== to ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert the functional change in the original CL, but keep the refactories. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ==========
Description was changed from ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert the functional change in the original CL, but keep the refactories. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ========== to ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert just PaintLayer.cpp so that we don't destroy a layer's scrollable area once it is created, until the layer is destroyed. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ==========
Description was changed from ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert just PaintLayer.cpp so that we don't destroy a layer's scrollable area once it is created, until the layer is destroyed. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ========== to ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert just PaintLayer.cpp so that we don't destroy a layer's scrollable area once it is created, until the layer is destroyed. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ==========
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755243002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755243002/260001
The CQ bit was unchecked by wangxianzhu@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755243002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755243002/260001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Patchset #3 (id:260001) has been deleted
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755243002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755243002/240001
Description was changed from ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert just PaintLayer.cpp so that we don't destroy a layer's scrollable area once it is created, until the layer is destroyed. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ========== to ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert functional changes, but keep refactories. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ==========
The CQ bit was unchecked by wangxianzhu@chromium.org
The CQ bit was checked by wangxianzhu@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755243002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755243002/240001
Message was sent while issue was closed.
Description was changed from ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert functional changes, but keep refactories. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ========== to ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert functional changes, but keep refactories. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:240001)
Message was sent while issue was closed.
Description was changed from ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert functional changes, but keep refactories. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 ========== to ========== Partly revert of Conditionally create PaintLayer's scrollable area object (patchset #8 id:140001 of https://codereview.chromium.org/1643663002/ ) Reason for revert: Caused bug 591045. CompositedLayerMapping and ScrollingCoordinator don't expect scrollableArea of a layer to disappear. Revert functional changes, but keep refactories. BUG=591045 Original issue's description: > Conditionally create PaintLayer's scrollable area object > > BUG=467721 > > Committed: https://crrev.com/e3e7bae15616191d743019b9a5b77ac201aec20e > Cr-Commit-Position: refs/heads/master@{#378247} TBR=chrishtr@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=467721 Committed: https://crrev.com/b772a3d31c12361e22a8d6950cbef821ac3dc7d5 Cr-Commit-Position: refs/heads/master@{#378845} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b772a3d31c12361e22a8d6950cbef821ac3dc7d5 Cr-Commit-Position: refs/heads/master@{#378845} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
