Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 1755243002: Partly revert of Conditionally create PaintLayer's scrollable area object (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@PaintLayerClipper
Patch Set: Partly revert Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 726 matching lines...) Expand 10 before | Expand all | Expand 10 after
737 737
738 bool shouldBeSelfPaintingLayer() const; 738 bool shouldBeSelfPaintingLayer() const;
739 739
740 // FIXME: We should only create the stacking node if needed. 740 // FIXME: We should only create the stacking node if needed.
741 bool requiresStackingNode() const { return true; } 741 bool requiresStackingNode() const { return true; }
742 void updateStackingNode(); 742 void updateStackingNode();
743 743
744 void updateReflectionInfo(const ComputedStyle*); 744 void updateReflectionInfo(const ComputedStyle*);
745 FilterEffectBuilder* updateFilterEffectBuilder() const; 745 FilterEffectBuilder* updateFilterEffectBuilder() const;
746 746
747 bool requiresScrollableArea() const { return m_layoutObject->hasOverflowClip () || m_layoutObject->isLayoutView() || m_layoutObject->styleRef().resize() != R ESIZE_NONE; } 747 // FIXME: We could lazily allocate our ScrollableArea based on style propert ies ('overflow', ...)
748 // but for now, we are always allocating it for LayoutBox as it's safer. crb ug.com/467721.
749 bool requiresScrollableArea() const { return layoutBox(); }
748 void updateScrollableArea(); 750 void updateScrollableArea();
749 751
750 void dirtyAncestorChainVisibleDescendantStatus(); 752 void dirtyAncestorChainVisibleDescendantStatus();
751 753
752 bool attemptDirectCompositingUpdate(StyleDifference, const ComputedStyle* ol dStyle); 754 bool attemptDirectCompositingUpdate(StyleDifference, const ComputedStyle* ol dStyle);
753 void updateTransform(const ComputedStyle* oldStyle, const ComputedStyle& new Style); 755 void updateTransform(const ComputedStyle* oldStyle, const ComputedStyle& new Style);
754 756
755 void dirty3DTransformedDescendantStatus(); 757 void dirty3DTransformedDescendantStatus();
756 // Both updates the status, and returns true if descendants of this have 3d. 758 // Both updates the status, and returns true if descendants of this have 3d.
757 bool update3DTransformedDescendantStatus(); 759 bool update3DTransformedDescendantStatus();
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
872 874
873 } // namespace blink 875 } // namespace blink
874 876
875 #ifndef NDEBUG 877 #ifndef NDEBUG
876 // Outside the WebCore namespace for ease of invocation from gdb. 878 // Outside the WebCore namespace for ease of invocation from gdb.
877 void showLayerTree(const blink::PaintLayer*); 879 void showLayerTree(const blink::PaintLayer*);
878 void showLayerTree(const blink::LayoutObject*); 880 void showLayerTree(const blink::LayoutObject*);
879 #endif 881 #endif
880 882
881 #endif // Layer_h 883 #endif // Layer_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698