Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1755223002: Adds WindowManagerManager to mus (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds WindowManagerManager to mus WindowTreeHostImpl now has a set of WindowManagerManagers. There are two distinct modes: . Created by way of using WindowTreeHostFactory. In this mode there is only one WindowManagerManager for the host. . Created implicitly when no WindowTreeHostFactorys have been used. In this mode there is a WindowManagerManager per userid. This patch doesn't enforce WindowTreeClients only created windows under the WindowManager with the id. That'll come after this. Additionally there is a lot of cleanup to do, but I'm trying to minimize the extent of the changes, which are already quite large. I've changed mash (desktop_wm) so that it no longer uses WindowTreeHostFactory. This triggers having mus create a default WindowTreeHost (the second mode above). BUG=590955 TEST=covered by tests R=ben@chromium.org BUG= Committed: https://crrev.com/cbe425b94131041e3a754c18c269702acd624880 Cr-Commit-Position: refs/heads/master@{#378809}

Patch Set 1 #

Patch Set 2 : merge and WindowManagerState #

Unified diffs Side-by-side diffs Delta from patch set Stats (+692 lines, -222 lines) Patch
M components/mus/mus_app.h View 1 chunk +16 lines, -13 lines 0 comments Download
M components/mus/mus_app.cc View 5 chunks +44 lines, -13 lines 0 comments Download
M components/mus/ws/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download
M components/mus/ws/client_connection.h View 1 chunk +11 lines, -5 lines 0 comments Download
M components/mus/ws/client_connection.cc View 3 chunks +15 lines, -1 line 0 comments Download
M components/mus/ws/connection_manager.h View 1 10 chunks +33 lines, -12 lines 0 comments Download
M components/mus/ws/connection_manager.cc View 1 11 chunks +112 lines, -87 lines 0 comments Download
M components/mus/ws/connection_manager_delegate.h View 2 chunks +19 lines, -2 lines 0 comments Download
M components/mus/ws/window_manager_access_policy.cc View 1 chunk +5 lines, -3 lines 0 comments Download
A components/mus/ws/window_manager_factory_registry.h View 1 chunk +52 lines, -0 lines 0 comments Download
A components/mus/ws/window_manager_factory_registry.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M components/mus/ws/window_manager_factory_service.h View 2 chunks +10 lines, -1 line 0 comments Download
M components/mus/ws/window_manager_factory_service.cc View 1 chunk +12 lines, -1 line 0 comments Download
A components/mus/ws/window_manager_state.h View 1 1 chunk +58 lines, -0 lines 0 comments Download
A components/mus/ws/window_manager_state.cc View 1 1 chunk +41 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.h View 1 10 chunks +32 lines, -12 lines 0 comments Download
M components/mus/ws/window_tree_host_impl.cc View 1 11 chunks +120 lines, -26 lines 0 comments Download
M components/mus/ws/window_tree_impl.cc View 1 11 chunks +37 lines, -23 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 1 4 chunks +13 lines, -5 lines 0 comments Download
M mash/wm/root_window_controller.h View 2 chunks +0 lines, -4 lines 0 comments Download
M mash/wm/root_window_controller.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M mash/wm/window_manager_application.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
sky
4 years, 9 months ago (2016-03-02 18:22:17 UTC) #1
Ben Goodger (Google)
lgtm, just choose a better name than WindowManagerManager.
4 years, 9 months ago (2016-03-02 18:58:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755223002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755223002/20001
4 years, 9 months ago (2016-03-02 19:25:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 20:04:39 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 20:06:07 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cbe425b94131041e3a754c18c269702acd624880
Cr-Commit-Position: refs/heads/master@{#378809}

Powered by Google App Engine
This is Rietveld 408576698