components/mus/ws/window_manager_access_policy.cc - Issue 1755223002: Adds WindowManagerManager to mus

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/ws/window_manager_access_policy.cc

Issue 1755223002: Adds WindowManagerManager to mus (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge and WindowManagerState Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/mus/ws/window_manager_access_policy.cc

diff --git a/components/mus/ws/window_manager_access_policy.cc b/components/mus/ws/window_manager_access_policy.cc

index b69a53fb1e0906e1ade9b98b53083b716e0f6c79..ccc5868b4b48cd1314582bec1dff1df568aad071 100644

--- a/components/mus/ws/window_manager_access_policy.cc

+++ b/components/mus/ws/window_manager_access_policy.cc

@@ -71,9 +71,11 @@ bool WindowManagerAccessPolicy::CanEmbed(const ServerWindow* window,

bool WindowManagerAccessPolicy::CanChangeWindowVisibility(

const ServerWindow* window) const {

- // The WindowManager can change the visibility of the root too.

- return window->id().connection_id == connection_id_ ||

- (window->GetRoot() == window);

+ if (window->id().connection_id == connection_id_)

+ return true;

+ // The WindowManager can change the visibility of the WindowManager root.

+ const ServerWindow* root = window->GetRoot();

+ return root && window->parent() == root;

}

bool WindowManagerAccessPolicy::CanSetWindowSurface(