Timeline: quit using Progress, introduce TimelineLifecycleDelegate

Timeline: quit using Progress, introduce TimelineLifecycleDelegate

- let TimelineLoader operate on TracingModel, not TimelineModel;
- introduce TimelineLifecycleDelegate, implemented by TimelinePanel;
- do not use Progress/ProgressIndicator in Timeline, use StatusPane instead
    for consistency with recording and fetching;
- use callback, not event in TimelineStatusPane to indicate stop is requested;
- rename "Finish" to "Stop" in the status pane.

BUG=

Committed: https://crrev.com/38a9ca0718c9855694328b19955bb6486b5c1158
Cr-Commit-Position: refs/heads/master@{#378898}

[caseq, 2016-03-02 20:08:31]

caseq@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-03-02 21:03:12]

lgtm

https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html
(right):

https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html:29:
WebInspector.TimelineLoader.loadFromFile(model, {}, new
WebInspector.TimelineLifecycleDelegate());
Don't you want to test how the delegate is working?

https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html:52:
InspectorTest.addResult("Model is empty: " + (!model.minimumRecordTime() &&
!model.maximumRecordTime()));
why?

https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1278:
WebInspector.TimelineLifecycleDelegate = function()
Looks like a regular progress indicator delegate interface. Should we call it
accordingly, e.g. ProgressDelegate ?

https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1862:
this._timeLine.classList.remove("hidden");
Doesn't seem good when controls move around dialog during operation.

[caseq, 2016-03-02 23:01:42]

On 2016/03/02 21:03:12, alph wrote:
>
https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/LayoutTe...
> File
third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html
> (right):
> 
>
https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html:29:
> WebInspector.TimelineLoader.loadFromFile(model, {}, new
> WebInspector.TimelineLifecycleDelegate());
> Don't you want to test how the delegate is working?

Thanks, good idea, done!

> 
>
https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html:52:
> InspectorTest.addResult("Model is empty: " + (!model.minimumRecordTime() &&
> !model.maximumRecordTime()));
> why?

We're changing from timeline model to tracing model and I don't want to
introduce isEmpty() there.


>
https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/Source/d...
> File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
> (right):
> 
>
https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/Source/d...
> third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1278:
> WebInspector.TimelineLifecycleDelegate = function()
> Looks like a regular progress indicator delegate interface. Should we call it
> accordingly, e.g. ProgressDelegate ?

This is going to become more specific to Timeline with the following patch, so
bear with me.

>
https://codereview.chromium.org/1755123003/diff/1/third_party/WebKit/Source/d...
> third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1862:
> this._timeLine.classList.remove("hidden");
> Doesn't seem good when controls move around dialog during operation.

Fixed by exposing it as a construction-time flag.

[caseq, 2016-03-02 23:21:07]

Patchset #2 (id:20001) has been deleted

[caseq, 2016-03-02 23:24:42]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-03-02 23:24:43]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/1755123003/#ps40001
(title: "review comments addressed")

[commit-bot: I haz the power, 2016-03-02 23:25:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755123003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755123003/40001

[commit-bot: I haz the power, 2016-03-03 00:49:54]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-03 00:51:02]

Description was changed from

==========
Timeline: quit using Progress, introduce TimelineLifecycleDelegate

- let TimelineLoader operate on TracingModel, not TimelineModel;
- introduce TimelineLifecycleDelegate, implemented by TimelinePanel;
- do not use Progress/ProgressIndicator in Timeline, use StatusPane instead
    for consistency with recording and fetching;
- use callback, not event in TimelineStatusPane to indicate stop is requested;
- rename "Finish" to "Stop" in the status pane.

BUG=
==========

to

==========
Timeline: quit using Progress, introduce TimelineLifecycleDelegate

- let TimelineLoader operate on TracingModel, not TimelineModel;
- introduce TimelineLifecycleDelegate, implemented by TimelinePanel;
- do not use Progress/ProgressIndicator in Timeline, use StatusPane instead
    for consistency with recording and fetching;
- use callback, not event in TimelineStatusPane to indicate stop is requested;
- rename "Finish" to "Stop" in the status pane.

BUG=

Committed: https://crrev.com/38a9ca0718c9855694328b19955bb6486b5c1158
Cr-Commit-Position: refs/heads/master@{#378898}
==========

[commit-bot: I haz the power, 2016-03-03 00:51:03]

Patchset 2 (id:??) landed as
https://crrev.com/38a9ca0718c9855694328b19955bb6486b5c1158
Cr-Commit-Position: refs/heads/master@{#378898}