third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load-expected.txt - Issue 1755123003: Timeline: quit using Progress, introduce TimelineLifecycleDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load-expected.txt

Issue 1755123003: Timeline: quit using Progress, introduce TimelineLifecycleDelegate (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html ('k') | third_party/WebKit/Source/devtools/front_end/timeline/TimelineLoader.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load-expected.txt

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load-expected.txt b/third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load-expected.txt

index 9d01dc27811fe98eeedb4c5a63d6cf7c4e3240f4..cf66b45629f517ceb9d7aabd8daf9ffcd115dc95 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load-expected.txt

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load-expected.txt

@@ -2,18 +2,23 @@ Tests tracing based Timeline save/load functionality.

Running: testNormal

+TimelineLifecycleDelegate.loadingStarted()

+TimelineLifecycleDelegate.loadingProgress()

+TimelineLifecycleDelegate.loadingComplete(true)

Saved data is equal to restored data: true

Running: testJSONObjectFormat

+TimelineLifecycleDelegate.loadingStarted()

+TimelineLifecycleDelegate.loadingProgress()

+TimelineLifecycleDelegate.loadingComplete(true)

Saved data is equal to restored data: true

Running: testBroken

-error: TracingStartedInPage event not found.

+TimelineLifecycleDelegate.loadingStarted()

+TimelineLifecycleDelegate.loadingComplete(true)

Model is empty: true

Running: testMalformedJSON

-error: TracingStartedInPage event not found.

+TimelineLifecycleDelegate.loadingComplete(false)

Model is empty: true