chrome/browser/password_manager/native_backend_libsecret_unittest.cc - Issue 1755053002: CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

Issue 1755053002: CREDENTIAL: Serialize 'PasswordCredential' objects with "" as the federation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: vasilii Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_libsecret.cc ('k') | components/password_manager/core/browser/login_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_libsecret_unittest.cc

diff --git a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

index f3437863ec239f17acfd3e0c73ced0df48bb3abc..2fa1cf4eea3c82c1f92fe4c77075c79f113be693 100644

--- a/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

+++ b/chrome/browser/password_manager/native_backend_libsecret_unittest.cc

@@ -398,8 +398,12 @@ class NativeBackendLibsecretTest : public testing::Test {

base::Int64ToString(form.date_synced.ToInternalValue()));

CheckStringAttribute(item, "display_name", UTF16ToUTF8(form.display_name));

CheckStringAttribute(item, "avatar_url", form.icon_url.spec());

+ // We serialize unique origins as "", in order to make other systems that

+ // read from the login database happy. https://crbug.com/591310

CheckStringAttribute(item, "federation_url",

- form.federation_origin.Serialize());

+ form.federation_origin.unique()

+ ? ""

+ : form.federation_origin.Serialize());

CheckUint32Attribute(item, "should_skip_zero_click", form.skip_zero_click);

CheckUint32Attribute(item, "generation_upload_status",

form.generation_upload_status);