[wasm] add rotate opcodes

[wasm] add rotate opcodes

BUG=

Committed: https://crrev.com/9d0cf920bd59389f3ec408fa93aa6277a9cdab9c
Cr-Commit-Position: refs/heads/master@{#34455}

[Weiliang, 2016-03-02 08:38:13]

Description was changed from

==========
[wasm] add rotate opcodes

BUG=
==========

to

==========
[wasm] add rotate opcodes

BUG=
==========

[Weiliang, 2016-03-02 08:38:13]

weiliang.lin@intel.com changed reviewers:
+ titzer@chromium.org

[dougc, 2016-03-02 09:11:57]

On 2016/03/02 08:38:38, Weiliang wrote:

Note sure if all the opcodes should be renumbered as tools have them baked in.
Perhaps just pick two unused numbers for rol and ror.

[titzer, 2016-03-02 22:17:40]

Looks good other than the renumbering.

https://codereview.chromium.org/1755013003/diff/1/src/wasm/wasm-opcodes.h
File src/wasm/wasm-opcodes.h (right):

https://codereview.chromium.org/1755013003/diff/1/src/wasm/wasm-opcodes.h#new...
src/wasm/wasm-opcodes.h:151: V(I32Ror, 0x4d, i_ii)           \
Please don't renumber here, since other tools will need to catch up.

Unfortunately you'll have to pick some numbers at the end until we renumber
everything in one go.

[Weiliang, 2016-03-03 03:18:22]

On 2016/03/02 22:17:40, titzer wrote:
> Looks good other than the renumbering.
> 
> https://codereview.chromium.org/1755013003/diff/1/src/wasm/wasm-opcodes.h
> File src/wasm/wasm-opcodes.h (right):
> 
>
https://codereview.chromium.org/1755013003/diff/1/src/wasm/wasm-opcodes.h#new...
> src/wasm/wasm-opcodes.h:151: V(I32Ror, 0x4d, i_ii)           \
> Please don't renumber here, since other tools will need to catch up.
> 
> Unfortunately you'll have to pick some numbers at the end until we renumber
> everything in one go.

Thanks for comments, PTAL patch set 2

Thanks
-Weiliang

[titzer, 2016-03-03 04:15:03]

lgtm

[Weiliang, 2016-03-03 04:36:30]

The CQ bit was checked by weiliang.lin@intel.com

[commit-bot: I haz the power, 2016-03-03 04:36:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1755013003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1755013003/20001

[commit-bot: I haz the power, 2016-03-03 05:10:23]

Description was changed from

==========
[wasm] add rotate opcodes

BUG=
==========

to

==========
[wasm] add rotate opcodes

BUG=
==========

[commit-bot: I haz the power, 2016-03-03 05:10:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-03 05:11:18]

Description was changed from

==========
[wasm] add rotate opcodes

BUG=
==========

to

==========
[wasm] add rotate opcodes

BUG=

Committed: https://crrev.com/9d0cf920bd59389f3ec408fa93aa6277a9cdab9c
Cr-Commit-Position: refs/heads/master@{#34455}
==========

[commit-bot: I haz the power, 2016-03-03 05:11:19]

Patchset 2 (id:??) landed as
https://crrev.com/9d0cf920bd59389f3ec408fa93aa6277a9cdab9c
Cr-Commit-Position: refs/heads/master@{#34455}