Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1755003002: Remove MOJO_DISALLOW_COPY_AND_ASSIGN and MOJO_ALLOW_UNUSED_LOCAL. (Closed)

Created:
4 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MOJO_DISALLOW_COPY_AND_ASSIGN and MOJO_ALLOW_UNUSED_LOCAL. BUG=534695 Committed: https://crrev.com/432564c6ecff52ab735bdc35adcf537d89b13589 Cr-Commit-Position: refs/heads/master@{#378891}

Patch Set 1 #

Patch Set 2 : Fix GN check. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -199 lines) Patch
M components/mus/common/window_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/public/cpp/lib/window_private.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/lib/window_tree_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/test_window.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_server_test_base.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_server_test_suite.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/public/cpp/tests/window_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M components/mus/public/cpp/window.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/ws/window_manager_client_apptest.cc View 13 chunks +13 lines, -13 lines 0 comments Download
M components/mus/ws/window_tree_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/resource_provider/resource_provider_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/embedder/platform_channel_pair.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/embedder/platform_channel_pair_posix_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/embedder/platform_shared_buffer.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/embedder/process_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/async_waiter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/awakable_list.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/awakable_list_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/core_test_base.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/mapping_table.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/options_validation.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/test_utils.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/edk/system/waiter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/waiter_test_utils.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/waiter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/test/multiprocess_test_helper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/test/scoped_ipc_support.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/test/test_support_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/gles2/gles2_context.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/c/system/macros.h View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/public/c/system/tests/core_perftest.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M mojo/public/c/system/tests/macros_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/public/cpp/bindings/lib/bounds_checker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/connector.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/control_message_proxy.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/fixed_buffer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/cpp/bindings/lib/message_builder.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/shared_data.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/shared_ptr.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/validate_params.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/lib/validation_errors.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/message.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/binding_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M mojo/public/cpp/bindings/tests/bindings_perftest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/equals_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/message_queue.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_apptest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/versioning_test_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/async_waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/environment.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/environment/lib/default_async_waiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/lib/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/environment/lib/scoped_task_tracking.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/environment/logging.h View 2 chunks +2 lines, -1 line 0 comments Download
M mojo/public/cpp/environment/tests/async_wait_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/environment/tests/async_waiter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/cpp/environment/tests/logging_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/system/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/cpp/system/buffer.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/cpp/system/data_pipe.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/cpp/system/handle.h View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/public/cpp/system/macros.h View 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/public/cpp/system/message_pipe.h View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/cpp/system/tests/macros_unittest.cc View 3 chunks +2 lines, -20 lines 0 comments Download
M mojo/public/cpp/utility/lib/thread.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M mojo/public/cpp/utility/mutex.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/cpp/utility/run_loop.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/utility/tests/mutex_unittest.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M mojo/public/cpp/utility/tests/run_loop_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M mojo/public/cpp/utility/tests/thread_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/utility/thread.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/union_definition.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/test_service/test_request_tracker_application.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/test_service/test_request_tracker_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/test_service/test_service_application.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/test_service/test_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/test_service/test_time_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/application_runner.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/application_test_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/public/cpp/lib/connection_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/lib/interface_factory_binder.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/shell_client.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/public/cpp/shell_connection.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Anand Mistry (off Chromium)
4 years, 9 months ago (2016-03-02 05:30:11 UTC) #2
jam
lgtm
4 years, 9 months ago (2016-03-02 19:13:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1755003002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1755003002/40001
4 years, 9 months ago (2016-03-02 22:33:27 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-03 00:26:23 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 00:27:42 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/432564c6ecff52ab735bdc35adcf537d89b13589
Cr-Commit-Position: refs/heads/master@{#378891}

Powered by Google App Engine
This is Rietveld 408576698