Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: mojo/public/cpp/utility/mutex.h

Issue 1755003002: Remove MOJO_DISALLOW_COPY_AND_ASSIGN and MOJO_ALLOW_UNUSED_LOCAL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/public/cpp/utility/lib/thread.cc ('k') | mojo/public/cpp/utility/run_loop.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_PUBLIC_CPP_UTILITY_MUTEX_H_ 5 #ifndef MOJO_PUBLIC_CPP_UTILITY_MUTEX_H_
6 #define MOJO_PUBLIC_CPP_UTILITY_MUTEX_H_ 6 #define MOJO_PUBLIC_CPP_UTILITY_MUTEX_H_
7 7
8 #ifdef _WIN32 8 #ifdef _WIN32
9 #error "Not implemented: See crbug.com/342893." 9 #error "Not implemented: See crbug.com/342893."
10 #endif 10 #endif
11 11
12 #include <pthread.h> 12 #include <pthread.h>
13 13
14 #include "base/macros.h"
14 #include "mojo/public/cpp/system/macros.h" 15 #include "mojo/public/cpp/system/macros.h"
15 16
16 namespace mojo { 17 namespace mojo {
17 18
18 #ifdef NDEBUG 19 #ifdef NDEBUG
19 // Note: Make a C++ constant for |PTHREAD_MUTEX_INITIALIZER|. (We can't directly 20 // Note: Make a C++ constant for |PTHREAD_MUTEX_INITIALIZER|. (We can't directly
20 // use the C macro in an initializer list, since it might expand to |{ ... }|.) 21 // use the C macro in an initializer list, since it might expand to |{ ... }|.)
21 namespace internal { 22 namespace internal {
22 const pthread_mutex_t kPthreadMutexInitializer = PTHREAD_MUTEX_INITIALIZER; 23 const pthread_mutex_t kPthreadMutexInitializer = PTHREAD_MUTEX_INITIALIZER;
23 } 24 }
(...skipping 17 matching lines...) Expand all
41 void Lock(); 42 void Lock();
42 void Unlock(); 43 void Unlock();
43 bool TryLock(); 44 bool TryLock();
44 45
45 void AssertHeld(); 46 void AssertHeld();
46 #endif 47 #endif
47 48
48 private: 49 private:
49 pthread_mutex_t mutex_; 50 pthread_mutex_t mutex_;
50 51
51 MOJO_DISALLOW_COPY_AND_ASSIGN(Mutex); 52 DISALLOW_COPY_AND_ASSIGN(Mutex);
52 }; 53 };
53 54
54 class MutexLock { 55 class MutexLock {
55 public: 56 public:
56 explicit MutexLock(Mutex* mutex) : mutex_(mutex) { mutex_->Lock(); } 57 explicit MutexLock(Mutex* mutex) : mutex_(mutex) { mutex_->Lock(); }
57 ~MutexLock() { mutex_->Unlock(); } 58 ~MutexLock() { mutex_->Unlock(); }
58 59
59 private: 60 private:
60 Mutex* const mutex_; 61 Mutex* const mutex_;
61 62
62 MOJO_DISALLOW_COPY_AND_ASSIGN(MutexLock); 63 DISALLOW_COPY_AND_ASSIGN(MutexLock);
63 }; 64 };
64 65
65 // Catch bug where variable name is omitted (e.g., |MutexLock (&mu)|). 66 // Catch bug where variable name is omitted (e.g., |MutexLock (&mu)|).
66 #define MutexLock(x) static_assert(0, "MutexLock() missing variable name"); 67 #define MutexLock(x) static_assert(0, "MutexLock() missing variable name");
67 68
68 } // namespace mojo 69 } // namespace mojo
69 70
70 #endif // MOJO_PUBLIC_CPP_UTILITY_MUTEX_H_ 71 #endif // MOJO_PUBLIC_CPP_UTILITY_MUTEX_H_
OLDNEW
« no previous file with comments | « mojo/public/cpp/utility/lib/thread.cc ('k') | mojo/public/cpp/utility/run_loop.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698