Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 175473003: Fixed incorrect resize of docked windows when locking screen. (Closed)

Created:
6 years, 10 months ago by Albert Bodenhamer
Modified:
6 years, 10 months ago
Reviewers:
Harry McCleave
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed incorrect resize of docked windows when locking screen. Switches updating of state_.is_screen_locked to push rather than pull. is_screen_locked is set when the lock animation starts and unset when OnLockStateChanged is called with locked unset. If is_screen_locked is set avoid generating notifications about inset changes. BUG=338377 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252785

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M ash/shelf/shelf_layout_manager.cc View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Albert Bodenhamer
6 years, 10 months ago (2014-02-21 19:33:14 UTC) #1
Harry McCleave
lgtm
6 years, 10 months ago (2014-02-21 19:36:05 UTC) #2
Albert Bodenhamer
The CQ bit was checked by abodenha@chromium.org
6 years, 10 months ago (2014-02-21 19:40:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/175473003/1
6 years, 10 months ago (2014-02-21 19:42:58 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 21:43:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268014
6 years, 10 months ago (2014-02-21 21:44:00 UTC) #6
Albert Bodenhamer
The CQ bit was checked by abodenha@chromium.org
6 years, 10 months ago (2014-02-21 21:53:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/175473003/1
6 years, 10 months ago (2014-02-21 21:56:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 00:18:47 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268172
6 years, 10 months ago (2014-02-22 00:18:47 UTC) #10
Albert Bodenhamer
The CQ bit was checked by abodenha@chromium.org
6 years, 10 months ago (2014-02-22 00:54:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/175473003/1
6 years, 10 months ago (2014-02-22 00:55:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abodenha@chromium.org/175473003/1
6 years, 10 months ago (2014-02-22 01:35:55 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 08:35:23 UTC) #14
Message was sent while issue was closed. 
Change committed as 252785

Powered by Google App Engine
This is Rietveld 408576698