Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1754523006: Beginning fix for KeyEvent,KeyboardEvent and UIEvent changes in roll 45 (Closed)

Created:
4 years, 9 months ago by terry
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : More explicit test result #

Patch Set 3 : Undo html.status change #

Patch Set 4 : Undo html.status change #

Patch Set 5 : Revert html.status changes #

Patch Set 6 : Merged #

Patch Set 7 : Working of dart2 analyzer error #

Patch Set 8 : Fixes to match 45 IDLs #

Patch Set 9 : Cleanup #

Patch Set 10 : CL ready #

Patch Set 11 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -69 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 3 4 5 6 7 8 11 chunks +17 lines, -21 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 2 3 4 5 6 7 9 chunks +12 lines, -27 lines 0 comments Download
M tools/dom/scripts/dartdomgenerator.py View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -0 lines 0 comments Download
M tools/dom/src/dart2js_KeyEvent.dart View 1 2 3 4 5 6 7 8 5 chunks +11 lines, -10 lines 0 comments Download
M tools/dom/src/dartium_KeyEvent.dart View 1 2 3 4 5 6 7 3 chunks +7 lines, -10 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_KeyboardEvent.darttemplate View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_KeyboardEvent.darttemplate View 1 2 3 4 5 6 7 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
terry
Committed patchset #11 (id:200001) manually as 5c3728b067e89cf220e264997426a9fd32de0309 (presubmit successful).
4 years, 9 months ago (2016-03-07 15:52:11 UTC) #4
Bill Hesse
4 years, 9 months ago (2016-03-07 16:44:04 UTC) #5
Message was sent while issue was closed. 
On 2016/03/07 15:52:11, terry wrote:
> Committed patchset #11 (id:200001) manually as
> 5c3728b067e89cf220e264997426a9fd32de0309 (presubmit successful).

This fixes some issues, so you need to remove them from the whitelist at
tests/compiler/dart2js/analyze_api_test.dart 

It also creates some more issues, as you can see at:
https://build.chromium.org/p/client.dart/builders/dart2js-linux-jsshell-4-4-b...

So the whitelist also needs things added to it, as well as removed.

Powered by Google App Engine
This is Rietveld 408576698