Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 1754523006: Beginning fix for KeyEvent,KeyboardEvent and UIEvent changes in roll 45 (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Merged Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/scripts/dartdomgenerator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 84ff41892d75c5cec5d13f6c9afad61038c9395f..19d699640d9844e5dc8ae4aeb5df2e1c2ab4511e 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -24888,6 +24888,9 @@ class KeyboardEvent extends UIEvent {
@DomName('KeyboardEvent.charCode')
int get charCode => _charCode;
+ @DomName('KeyboardEvent.which')
+ int get which => _which;
+
@DomName('KeyboardEvent.KeyboardEvent')
@DocsEditable()
factory KeyboardEvent._(String type, [Map eventInitDict]) {
@@ -24934,11 +24937,6 @@ class KeyboardEvent extends UIEvent {
@DocsEditable()
bool get altKey => _blink.BlinkKeyboardEvent.instance.altKey_Getter_(unwrap_jso(this));
- @DomName('KeyboardEvent.charCode')
- @DocsEditable()
- @Experimental() // untriaged
- int get _charCode => _blink.BlinkKeyboardEvent.instance.charCode_Getter_(unwrap_jso(this));
-
@DomName('KeyboardEvent.code')
@DocsEditable()
@Experimental() // untriaged
@@ -24953,11 +24951,6 @@ class KeyboardEvent extends UIEvent {
@Experimental() // untriaged
String get key => _blink.BlinkKeyboardEvent.instance.key_Getter_(unwrap_jso(this));
- @DomName('KeyboardEvent.keyCode')
- @DocsEditable()
- @Experimental() // untriaged
- int get _keyCode => _blink.BlinkKeyboardEvent.instance.keyCode_Getter_(unwrap_jso(this));
-
@DomName('KeyboardEvent.keyIdentifier')
@DocsEditable()
@Experimental() // nonstandard
@@ -24986,11 +24979,6 @@ class KeyboardEvent extends UIEvent {
@DocsEditable()
bool get shiftKey => _blink.BlinkKeyboardEvent.instance.shiftKey_Getter_(unwrap_jso(this));
- @DomName('KeyboardEvent.which')
- @DocsEditable()
- @Experimental() // untriaged
- int get which => _blink.BlinkKeyboardEvent.instance.which_Getter_(unwrap_jso(this));
-
@DomName('KeyboardEvent.getModifierState')
@DocsEditable()
@Experimental() // untriaged
@@ -28641,7 +28629,7 @@ class MouseEvent extends UIEvent {
@DomName('MouseEvent.which')
@DocsEditable()
@Experimental() // untriaged
- int get which => _blink.BlinkMouseEvent.instance.which_Getter_(unwrap_jso(this));
+ int get _which => _blink.BlinkMouseEvent.instance.which_Getter_(unwrap_jso(this));
@DomName('MouseEvent.initMouseEvent')
@DocsEditable()
@@ -40263,7 +40251,7 @@ class UIEvent extends Event {
@DomName('UIEvent.which')
@DocsEditable()
@Unstable()
- int get which => _blink.BlinkUIEvent.instance.which_Getter_(unwrap_jso(this));
+ int get _which => _blink.BlinkUIEvent.instance.which_Getter_(unwrap_jso(this));
@DomName('UIEvent.initUIEvent')
@DocsEditable()
@@ -50681,22 +50669,22 @@ class KeyEvent extends _WrappedEvent implements KeyboardEvent {
/** The "fixed" value of whether the alt key is being pressed. */
bool _shadowAltKey;
- /** Caculated value of what the estimated charCode is for this event. */
+ /** Calculated value of what the estimated charCode is for this event. */
int _shadowCharCode;
- /** Caculated value of what the estimated keyCode is for this event. */
+ /** Calculated value of what the estimated keyCode is for this event. */
int _shadowKeyCode;
- /** Caculated value of what the estimated keyCode is for this event. */
+ /** Calculated value of what the estimated keyCode is for this event. */
int get keyCode => _shadowKeyCode;
- /** Caculated value of what the estimated charCode is for this event. */
+ /** Calculated value of what the estimated charCode is for this event. */
int get charCode => this.type == 'keypress' ? _shadowCharCode : 0;
- /** Caculated value of whether the alt key is pressed is for this event. */
+ /** Calculated value of whether the alt key is pressed is for this event. */
bool get altKey => _shadowAltKey;
- /** Caculated value of what the estimated keyCode is for this event. */
+ /** Calculated value of what the estimated keyCode is for this event. */
int get which => keyCode;
/** Accessor to the underlying keyCode value is the parent event. */
@@ -50777,6 +50765,7 @@ class KeyEvent extends _WrappedEvent implements KeyboardEvent {
int get _charCode => charCode;
int get _keyCode => keyCode;
+ int get _which => which;
String get _keyIdentifier {
throw new UnsupportedError("keyIdentifier is unsupported.");
}
@@ -50786,10 +50775,6 @@ class KeyEvent extends _WrappedEvent implements KeyboardEvent {
throw new UnsupportedError(
"Cannot initialize a KeyboardEvent from a KeyEvent.");
}
- int get _layerX => throw new UnsupportedError('Not applicable to KeyEvent');
- int get _layerY => throw new UnsupportedError('Not applicable to KeyEvent');
- int get _pageX => throw new UnsupportedError('Not applicable to KeyEvent');
- int get _pageY => throw new UnsupportedError('Not applicable to KeyEvent');
@Experimental() // untriaged
bool getModifierState(String keyArgument) => throw new UnimplementedError();
@Experimental() // untriaged
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/scripts/dartdomgenerator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698