Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: third_party/WebKit/Source/devtools/protocol.json

Issue 1754483002: [DevTools] Added setBlackboxPatterns method to protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@provide-hash-for-anonymous-scripts
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/protocol.json
diff --git a/third_party/WebKit/Source/devtools/protocol.json b/third_party/WebKit/Source/devtools/protocol.json
index 8ca06b8440503febf231b190c57ba0883171813b..903f08f7c058824f397cfe2503be222056112801 100644
--- a/third_party/WebKit/Source/devtools/protocol.json
+++ b/third_party/WebKit/Source/devtools/protocol.json
@@ -3371,6 +3371,11 @@
"description": "Call frame identifier."
},
{
+ "id": "ScriptHash",
+ "type": "string",
+ "description": "Script's content hash."
+ },
+ {
"id": "Location",
"type": "object",
"properties": [
@@ -3391,6 +3396,16 @@
"description": "Location in the source code."
},
{
+ "id": "BlackboxPattern",
+ "hidden": true,
+ "type": "object",
+ "properties": [
+ { "name": "regex", "type": "string", "optional": true },
+ { "name": "hash", "$ref": "ScriptHash", "optional": true }
+ ],
+ "description": "Blackbox pattern."
+ },
+ {
"id": "FunctionDetails",
"hidden": true,
"type": "object",
@@ -3790,13 +3805,21 @@
"description": "Removes AsyncOperation breakpoint."
},
{
- "name": "setBlackboxedRanges",
+ "name": "addBlackboxRanges",
"parameters": [
- { "name": "scriptId", "$ref": "Runtime.ScriptId", "description": "Id of the script." },
+ { "name": "hash", "$ref": "ScriptHash", "description": "Hash of the script." },
{ "name": "positions", "type": "array", "items": { "$ref": "ScriptPosition" } }
],
"hidden": true,
"description": "Makes backend skip steps in the script in blackboxed ranges. VM will try leave blacklisted scripts by performing 'step in' several times, finally resorting to 'step out' if unsuccessful. Positions array contains positions where blackbox state is changed. First interval isn't blackboxed. Array should be sorted."
+ },
+ {
+ "name": "editBlackboxPatterns",
pfeldman 2016/03/04 20:22:39 To recap: setBlackboxPatterns receives array of ei
kozy 2016/03/06 01:13:09 I will add hash support for breakpoints in separat
+ "parameters": [
+ { "name": "patterns", "type": "array", "items": { "$ref": "BlackboxPattern"} }
+ ],
+ "hidden": true,
+ "description": "Makes backend skip steps in the script in blackboxed ranges. VM will try leave blacklisted scripts by performing 'step in' several times, finally resorting to 'step out' if unsuccessful. Pattern can be one of the type: RegExp or script's hash. RegExp patterns will be replaced with passed, hashes will be added to current."
}
],
"events": [
@@ -3814,7 +3837,7 @@
{ "name": "endLine", "type": "integer", "description": "Last line of the script." },
{ "name": "endColumn", "type": "integer", "description": "Length of the last line of the script." },
{ "name": "executionContextId", "$ref": "Runtime.ExecutionContextId", "description": "Specifies script creation context.", "hidden": true },
- { "name": "hash", "type": "string", "hidden": true, "description": "Content hash of the script."},
+ { "name": "hash", "$ref": "ScriptHash", "hidden": true, "description": "Content hash of the script."},
{ "name": "isContentScript", "type": "boolean", "optional": true, "description": "Determines whether this script is a user extension script." },
{ "name": "isInternalScript", "type": "boolean", "optional": true, "description": "Determines whether this script is an internal script.", "hidden": true },
{ "name": "isLiveEdit", "type": "boolean", "optional": true, "description": "True, if this script is generated as a result of the live edit operation.", "hidden": true },
@@ -3834,7 +3857,7 @@
{ "name": "endLine", "type": "integer", "description": "Last line of the script." },
{ "name": "endColumn", "type": "integer", "description": "Length of the last line of the script." },
{ "name": "executionContextId", "$ref": "Runtime.ExecutionContextId", "description": "Specifies script creation context.", "hidden": true },
- { "name": "hash", "type": "string", "hidden": true, "description": "Content hash of the script."},
+ { "name": "hash", "$ref": "ScriptHash", "hidden": true, "description": "Content hash of the script."},
{ "name": "isContentScript", "type": "boolean", "optional": true, "description": "Determines whether this script is a user extension script." },
{ "name": "isInternalScript", "type": "boolean", "optional": true, "description": "Determines whether this script is an internal script.", "hidden": true },
{ "name": "sourceMapURL", "type": "string", "optional": true, "description": "URL of source map associated with script (if any)." },

Powered by Google App Engine
This is Rietveld 408576698