Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h

Issue 1754483002: [DevTools] Added setBlackboxPatterns method to protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@provide-hash-for-anonymous-scripts
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
index 39f8509aac37a320c9a19c24d59cd498b6c005ad..c476b5534c5833c546b55864932229139897dadc 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h
@@ -157,9 +157,11 @@ public:
void flushAsyncOperationEvents(ErrorString*) override;
void setAsyncOperationBreakpoint(ErrorString*, int operationId) override;
void removeAsyncOperationBreakpoint(ErrorString*, int operationId) override;
- void setBlackboxedRanges(ErrorString*,
- const String& scriptId,
+ void addBlackboxRanges(ErrorString*,
+ const String& hash,
PassOwnPtr<protocol::Array<protocol::Debugger::ScriptPosition>> positions) override;
+ void editBlackboxPatterns(ErrorString*,
+ PassOwnPtr<protocol::Array<protocol::Debugger::BlackboxPattern>> patterns) override;
void schedulePauseOnNextStatement(const String& breakReason, PassOwnPtr<protocol::DictionaryValue> data) override;
void cancelPauseOnNextStatement() override;
@@ -228,7 +230,8 @@ private:
bool isCallFrameWithUnknownScriptOrBlackboxed(PassRefPtr<JavaScriptCallFrame>);
void internalSetAsyncCallStackDepth(int);
- void increaseCachedSkipStackGeneration();
+
+ void restoreBlackboxState();
using ScriptsMap = HashMap<String, V8DebuggerScript>;
using BreakpointIdToDebuggerBreakpointIdsMap = HashMap<String, Vector<String>>;
@@ -286,7 +289,10 @@ private:
int m_currentAsyncOperationId;
bool m_pendingTraceAsyncOperationCompleted;
bool m_startingStepIntoAsync;
- HashMap<String, Vector<std::pair<int, int>>> m_blackboxedPositions;
+
+ HashSet<String> m_loadedScriptHashes;
pfeldman 2016/03/04 20:22:39 Should this be a map?
kozy 2016/03/06 01:13:09 It should be nothing. Removed.
+ HashMap<String, Vector<std::pair<int, int>>> m_hashToBlackboxPositions;
+ String m_blackboxPattern;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698