Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1754443002: - Add binary size analysis tool from Chromium. (Closed)

Created:
4 years, 9 months ago by Ivan Posva
Modified:
4 years, 9 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12697 lines, -0 lines) Patch
A runtime/third_party/binary_size/README.dart View 1 chunk +1 line, -0 lines 0 comments Download
A runtime/third_party/binary_size/src/binary_size_utils.py View 1 chunk +71 lines, -0 lines 0 comments Download
A runtime/third_party/binary_size/src/elf_symbolizer.py View 1 chunk +467 lines, -0 lines 0 comments Download
A runtime/third_party/binary_size/src/explain_binary_size_delta.py View 1 chunk +484 lines, -0 lines 0 comments Download
A runtime/third_party/binary_size/src/run_binary_size_analysis.py View 1 chunk +666 lines, -0 lines 0 comments Download
A runtime/third_party/binary_size/src/template/D3SymbolTreeMap.js View 1 chunk +938 lines, -0 lines 0 comments Download
A runtime/third_party/binary_size/src/template/index.html View 1 chunk +525 lines, -0 lines 0 comments Download
A runtime/third_party/binary_size/src/template/test-data-generator.html View 1 chunk +157 lines, -0 lines 0 comments Download
A runtime/third_party/d3/README.chromium View 1 chunk +31 lines, -0 lines 0 comments Download
A runtime/third_party/d3/README.dart View 1 chunk +1 line, -0 lines 0 comments Download
A runtime/third_party/d3/patches/001_no_html.patch View 1 chunk +24 lines, -0 lines 0 comments Download
A runtime/third_party/d3/src/LICENSE View 1 chunk +26 lines, -0 lines 0 comments Download
A runtime/third_party/d3/src/README.md View 1 chunk +9 lines, -0 lines 0 comments Download
A runtime/third_party/d3/src/d3.js View 1 chunk +9297 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
4 years, 9 months ago (2016-03-01 01:11:36 UTC) #2
Florian Schneider
lgtm
4 years, 9 months ago (2016-03-01 01:15:07 UTC) #3
Ivan Posva
4 years, 9 months ago (2016-03-01 18:06:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
890c86251a5384b6f30a82e7fed0150591e9e018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698