Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: runtime/third_party/d3/patches/001_no_html.patch

Issue 1754443002: - Add binary size analysis tool from Chromium. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/third_party/d3/README.dart ('k') | runtime/third_party/d3/src/LICENSE » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/third_party/d3/patches/001_no_html.patch
diff --git a/runtime/third_party/d3/patches/001_no_html.patch b/runtime/third_party/d3/patches/001_no_html.patch
new file mode 100644
index 0000000000000000000000000000000000000000..3c976b0b9c3232a4414b99743530d2e23fc59a5d
--- /dev/null
+++ b/runtime/third_party/d3/patches/001_no_html.patch
@@ -0,0 +1,24 @@
+diff --git a/third_party/d3/src/d3.js b/third_party/d3/src/d3.js
+index a3e4b95..8a98c4d 100644
+--- a/third_party/d3/src/d3.js
++++ b/third_party/d3/src/d3.js
+@@ -713,6 +713,7 @@
+ }) : this.node().textContent;
+ };
+ d3_selectionPrototype.html = function(value) {
++ throw "disallowed by chromium security";
+ return arguments.length ? this.each(typeof value === "function" ? function() {
+ var v = value.apply(this, arguments);
+ this.innerHTML = v == null ? "" : v;
+@@ -9274,9 +9275,11 @@
+ return JSON.parse(request.responseText);
+ }
+ d3.html = function(url, callback) {
++ throw "disallowed by chromium security";
+ return d3_xhr(url, "text/html", d3_html, callback);
+ };
+ function d3_html(request) {
++ throw "disallowed by chromium security";
+ var range = d3_document.createRange();
+ range.selectNode(d3_document.body);
+ return range.createContextualFragment(request.responseText);
« no previous file with comments | « runtime/third_party/d3/README.dart ('k') | runtime/third_party/d3/src/LICENSE » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698