Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1754393002: Fix current profile is unnecessary added to "Open link as" context menu. (Closed)

Created:
4 years, 9 months ago by lwchkg
Modified:
4 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix current profile is unnecessary added to "Open link as" context menu. The CL which introduced the bug is https://crrev.com/378323 This CL also updated a few tests for check for regressions of the same type. BUG=591331 TEST=pass the browser tests in this CL Committed: https://crrev.com/4c18bd250544470fff99ae1d9b631742d94a2983 Cr-Commit-Position: refs/heads/master@{#378999}

Patch Set 1 #

Patch Set 2 : Fix implicit conversion of signed and unsigned integers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -17 lines) Patch
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc View 1 6 chunks +23 lines, -12 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu_test_util.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
lwchkg
Dear Avi, PTAL. Regards, WC Leung.
4 years, 9 months ago (2016-03-02 18:51:16 UTC) #2
Avi (use Gerrit)
lgtm
4 years, 9 months ago (2016-03-02 19:32:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754393002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754393002/1
4 years, 9 months ago (2016-03-02 22:47:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/58713)
4 years, 9 months ago (2016-03-02 23:08:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754393002/20001
4 years, 9 months ago (2016-03-03 10:54:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-03 11:54:23 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-03 11:55:33 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4c18bd250544470fff99ae1d9b631742d94a2983
Cr-Commit-Position: refs/heads/master@{#378999}

Powered by Google App Engine
This is Rietveld 408576698