Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Unified Diff: chrome/browser/renderer_context_menu/render_view_context_menu.cc

Issue 1754393002: Fix current profile is unnecessary added to "Open link as" context menu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix implicit conversion of signed and unsigned integers Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_context_menu/render_view_context_menu.cc
diff --git a/chrome/browser/renderer_context_menu/render_view_context_menu.cc b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
index 44ce263c556ba97c79a46537fc5b14bb7e228034..a1e4bc7bf9376a04ca8be4eacf359fa1196b61c6 100644
--- a/chrome/browser/renderer_context_menu/render_view_context_menu.cc
+++ b/chrome/browser/renderer_context_menu/render_view_context_menu.cc
@@ -940,7 +940,7 @@ void RenderViewContextMenu::AppendLinkItems() {
entry->GetName()));
AddIconToLastMenuItem(entry->GetAvatarIcon(), &menu_model_);
} else if (target_profiles_entries.size() > 1u) {
- for (ProfileAttributesEntry* entry : entries) {
+ for (ProfileAttributesEntry* entry : target_profiles_entries) {
int menu_index = static_cast<int>(profile_link_paths_.size());
// In extreme cases, we might have more profiles than available
// command ids. In that case, just stop creating new entries - the
« no previous file with comments | « no previous file | chrome/browser/renderer_context_menu/render_view_context_menu_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698