Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1754353002: Revert of Begin weaning GrClipMaskManager off of GrDrawTarget (take 2) (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Begin weaning GrClipMaskManager off of GrDrawTarget (take 2) (patchset #7 id:120001 of https://codereview.chromium.org/1754563003/ ) Reason for revert: fAuditTrail Original issue's description: > Begin weaning GrClipMaskManager off of GrDrawTarget (take 2) > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1754563003 > > Committed: https://skia.googlesource.com/skia/+/86c60758e9e4f9e203d7462cb22b2a245a0f51bd TBR=joshualitt@chromium.org,bsalomon@google.com,joshualitt@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/8b8f36fc49b88ed369523730a4f1f26bb2094a75

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+276 lines, -483 lines) Patch
M gm/beziereffects.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M gm/bigrrectaaeffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/constcolorprocessor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/convexpolyeffect.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M gm/rrects.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M gm/texturedomaineffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/yuvtorgbeffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/gpu/GrClip.h View 1 chunk +0 lines, -7 lines 0 comments Download
M include/gpu/GrDrawContext.h View 5 chunks +3 lines, -10 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 2 chunks +23 lines, -23 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 13 chunks +183 lines, -184 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 6 chunks +24 lines, -150 lines 0 comments Download
D src/gpu/GrDrawContextPriv.h View 1 chunk +0 lines, -60 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +4 lines, -16 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/GrTest.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M tests/GLProgramsTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Begin weaning GrClipMaskManager off of GrDrawTarget (take 2)
4 years, 9 months ago (2016-03-02 16:52:52 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754353002/1
4 years, 9 months ago (2016-03-02 16:53:04 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 16:53:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8b8f36fc49b88ed369523730a4f1f26bb2094a75

Powered by Google App Engine
This is Rietveld 408576698