Issue 175423004: Revert 252466 "In order to support writing on windows we need to..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 175423004: Revert 252466 "In order to support writing on windows we need to..." (Closed)

Created:
6 years, 10 months ago by earthdok

Modified:
6 years, 10 months ago

Reviewers:
Drew Haven

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 252466 "In order to support writing on windows we need to..." Broke multiple MFYI bots (leaks, uninits). See issue. > In order to support writing on windows we need to take advantage of the new privileged operation in the utility thread. This code overlaps heavily with the Linux and OS X code, so all the writing for those is moved as well. > > BUG= > > Review URL: https://codereview.chromium.org/61643015 BUG=345659 TBR=haven@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252595

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -1450 lines)			Patch
M	trunk/src/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation.cc	View	2 chunks	+1 line, -7 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/image_writer_private/destroy_partitions_operation_unittest.cc	View	2 chunks	+26 lines, -20 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.h	View	1 chunk	+0 lines, -87 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/api/image_writer_private/image_writer_utility_client.cc	View	1 chunk	+0 lines, -158 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/image_writer_private/operation.h	View	5 chunks	+13 lines, -23 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/image_writer_private/operation.cc	View	7 chunks	+20 lines, -53 lines	0 comments	Download
A +	trunk/src/chrome/browser/extensions/api/image_writer_private/operation_linux.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/chrome/browser/extensions/api/image_writer_private/operation_mac.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/image_writer_private/operation_manager_unittest.cc	View	4 chunks	+0 lines, -28 lines	0 comments	Download
D	trunk/src/chrome/browser/extensions/api/image_writer_private/operation_nonchromeos.cc	View	1 chunk	+0 lines, -76 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/image_writer_private/operation_unittest.cc	View	5 chunks	+56 lines, -62 lines	0 comments	Download
A +	trunk/src/chrome/browser/extensions/api/image_writer_private/operation_win.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/image_writer_private/test_utils.h	View	2 chunks	+2 lines, -44 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/image_writer_private/test_utils.cc	View	2 chunks	+1 line, -73 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/image_writer_private/write_from_file_operation.cc	View	1 chunk	+6 lines, -12 lines	0 comments	Download
M	trunk/src/chrome/browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc	View	4 chunks	+4 lines, -22 lines	0 comments	Download
M	trunk/src/chrome/chrome.gyp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	trunk/src/chrome/chrome_browser_extensions.gypi	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	trunk/src/chrome/chrome_tests_unit.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome/common/chrome_utility_messages.h	View	2 chunks	+0 lines, -26 lines	0 comments	Download
M	trunk/src/chrome/utility/chrome_content_utility_client.cc	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/chrome/utility/chrome_content_utility_ipc_whitelist.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
D	trunk/src/chrome/utility/image_writer/OWNERS	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	trunk/src/chrome/utility/image_writer/error_messages.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	trunk/src/chrome/utility/image_writer/error_messages.cc	View	1 chunk	+0 lines, -24 lines	0 comments	Download
D	trunk/src/chrome/utility/image_writer/image_writer.h	View	1 chunk	+0 lines, -63 lines	0 comments	Download
D	trunk/src/chrome/utility/image_writer/image_writer.cc	View	1 chunk	+0 lines, -244 lines	0 comments	Download
D	trunk/src/chrome/utility/image_writer/image_writer_handler.h	View	1 chunk	+0 lines, -51 lines	0 comments	Download
D	trunk/src/chrome/utility/image_writer/image_writer_handler.cc	View	1 chunk	+0 lines, -151 lines	0 comments	Download
D	trunk/src/chrome/utility/image_writer/image_writer_unittest.cc	View	1 chunk	+0 lines, -182 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

earthdok

6 years, 10 months ago (2014-02-21 18:13:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r252595 (tree was closed).

Expand Messages | Collapse Messages