Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: trunk/src/chrome/browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc

Issue 175423004: Revert 252466 "In order to support writing on windows we need to..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc
===================================================================
--- trunk/src/chrome/browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc (revision 252593)
+++ trunk/src/chrome/browser/extensions/api/image_writer_private/write_from_file_operation_unittest.cc (working copy)
@@ -40,7 +40,7 @@
base::RunLoop().RunUntilIdle();
}
-// Runs the entire WriteFromFile operation.
+#if defined(OS_LINUX) && !defined(OS_CHROMEOS)
TEST_F(ImageWriterFromFileTest, WriteFromFileEndToEnd) {
MockOperationManager manager;
@@ -49,10 +49,6 @@
kDummyExtensionId,
test_image_path_,
test_device_path_.AsUTF8Unsafe());
-#if !defined(OS_CHROMEOS)
- scoped_refptr<FakeImageWriterClient> client = FakeImageWriterClient::Create();
- op->SetUtilityClientForTesting(client);
-#endif
EXPECT_CALL(manager,
OnProgress(kDummyExtensionId, image_writer_api::STAGE_WRITE, _))
@@ -63,9 +59,6 @@
EXPECT_CALL(manager,
OnProgress(kDummyExtensionId, image_writer_api::STAGE_WRITE, 100))
.Times(AtLeast(1));
-
-#if !defined(OS_CHROMEOS)
- // Chrome OS doesn't verify.
EXPECT_CALL(
manager,
OnProgress(kDummyExtensionId, image_writer_api::STAGE_VERIFYWRITE, _))
@@ -78,27 +71,16 @@
manager,
OnProgress(kDummyExtensionId, image_writer_api::STAGE_VERIFYWRITE, 100))
.Times(AtLeast(1));
-#endif
-
EXPECT_CALL(manager, OnComplete(kDummyExtensionId)).Times(1);
EXPECT_CALL(manager, OnError(kDummyExtensionId, _, _, _)).Times(0);
op->Start();
base::RunLoop().RunUntilIdle();
-#if !defined(OS_CHROMEOS)
- client->Progress(0);
- client->Progress(50);
- client->Progress(100);
- client->Success();
- base::RunLoop().RunUntilIdle();
- client->Progress(0);
- client->Progress(50);
- client->Progress(100);
- client->Success();
- base::RunLoop().RunUntilIdle();
-#endif
+
+ EXPECT_TRUE(base::ContentsEqual(test_image_path_, test_device_path_));
}
+#endif
} // namespace image_writer
} // namespace extensions
« no previous file with comments | « trunk/src/chrome/browser/extensions/api/image_writer_private/write_from_file_operation.cc ('k') | trunk/src/chrome/chrome.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698