Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 175423002: Add effect-based clipping for circular "tab" style rrects. (Closed)

Created:
6 years, 10 months ago by bsalomon
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add effect-based clipping for circular "tab" style rrects. BUG=skia:2181 Committed: http://code.google.com/p/skia/source/detail?r=13548

Patch Set 1 #

Patch Set 2 : update #

Total comments: 8

Patch Set 3 : Address Rob's comments #

Patch Set 4 : fix build warning #

Patch Set 5 : fix gcc warnings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -27 lines) Patch
M gm/rrects.cpp View 2 chunks +7 lines, -1 line 0 comments Download
M src/gpu/effects/GrRRectEffect.cpp View 1 2 3 4 8 chunks +172 lines, -26 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
bsalomon
6 years, 10 months ago (2014-02-21 19:09:32 UTC) #1
robertphillips
lgtm + nits & questions https://codereview.chromium.org/175423002/diff/30001/src/gpu/effects/GrRRectEffect.cpp File src/gpu/effects/GrRRectEffect.cpp (right): https://codereview.chromium.org/175423002/diff/30001/src/gpu/effects/GrRRectEffect.cpp#newcode183 src/gpu/effects/GrRRectEffect.cpp:183: builder->fsCodeAppend("\t\tvec2 dxy = max(vec2(dxy0.x, ...
6 years, 10 months ago (2014-02-21 19:26:36 UTC) #2
bsalomon
https://codereview.chromium.org/175423002/diff/30001/src/gpu/effects/GrRRectEffect.cpp File src/gpu/effects/GrRRectEffect.cpp (right): https://codereview.chromium.org/175423002/diff/30001/src/gpu/effects/GrRRectEffect.cpp#newcode183 src/gpu/effects/GrRRectEffect.cpp:183: builder->fsCodeAppend("\t\tvec2 dxy = max(vec2(dxy0.x, max(dxy0.y, dy1)), 0.0);\n"); On 2014/02/21 ...
6 years, 10 months ago (2014-02-21 21:20:45 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-21 21:38:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/175423002/70001
6 years, 10 months ago (2014-02-21 21:41:31 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 21:48:02 UTC) #6
commit-bot: I haz the power
Retried try job too often on Build-Mac10.8-Clang-x86-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildTests, BuildTools http://108.170.219.164:10117/buildstatus?builder=Build-Mac10.8-Clang-x86-Release-Trybot&number=108
6 years, 10 months ago (2014-02-21 21:48:03 UTC) #7
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-21 21:52:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/175423002/190001
6 years, 10 months ago (2014-02-21 21:52:13 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 22:05:01 UTC) #10
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu12-GCC-x86_64-Release-Trybot for step(s) BuildBench, BuildEverything, BuildGm, BuildTools http://108.170.219.164:10117/buildstatus?builder=Build-Ubuntu12-GCC-x86_64-Release-Trybot&number=1572
6 years, 10 months ago (2014-02-21 22:05:02 UTC) #11
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-21 22:05:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/175423002/290001
6 years, 10 months ago (2014-02-21 22:06:23 UTC) #13
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 22:41:59 UTC) #14
Message was sent while issue was closed. 
Change committed as 13548

Powered by Google App Engine
This is Rietveld 408576698