Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 1754003002: Properly handle unmanaged processes in mojo::shell:ChildProcessHost (Closed)

Created:
4 years, 9 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 9 months ago
Reviewers:
jabdelmalek, jam, boliu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, vmpstr+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In Chrome, we always let content launch child processes, and as such have no need for ChildProcessHost's synchronization logic. Furthermore, we use ChildProcessHost on the main thread where such logic is illegal. This updates ChildProcessHost to be more Chrome-friendly. BUG=591209, 591190 TBR=ben@chromium.org Committed: https://crrev.com/1a4ffc89ec7416f2ccc69d7e5a74e5ab2f30ab66 Cr-Commit-Position: refs/heads/master@{#378649}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M mojo/shell/runner/host/child_process_host.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.cc View 1 5 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Ken Rockot(use gerrit already)
4 years, 9 months ago (2016-03-01 23:28:17 UTC) #1
boliu
Verified locally fix works. Context is this fixes a flaky crash on android on cq. ...
4 years, 9 months ago (2016-03-01 23:39:11 UTC) #3
Ken Rockot(use gerrit already)
4 years, 9 months ago (2016-03-02 00:24:02 UTC) #5
Ken Rockot(use gerrit already)
On 2016/03/02 at 00:24:02, Ken Rockot wrote: > I've updated the CL to be less ...
4 years, 9 months ago (2016-03-02 00:24:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754003002/20001
4 years, 9 months ago (2016-03-02 00:24:54 UTC) #8
jabdelmalek
lgtm
4 years, 9 months ago (2016-03-02 00:34:55 UTC) #10
jam
lgtm
4 years, 9 months ago (2016-03-02 00:35:06 UTC) #11
boliu
PS2 verified locally too
4 years, 9 months ago (2016-03-02 01:26:45 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 02:04:09 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 02:06:25 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1a4ffc89ec7416f2ccc69d7e5a74e5ab2f30ab66
Cr-Commit-Position: refs/heads/master@{#378649}

Powered by Google App Engine
This is Rietveld 408576698