Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: mojo/shell/runner/host/child_process_host.h

Issue 1754003002: Properly handle unmanaged processes in mojo::shell:ChildProcessHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/shell/runner/host/child_process_host.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SHELL_RUNNER_HOST_CHILD_PROCESS_HOST_H_ 5 #ifndef MOJO_SHELL_RUNNER_HOST_CHILD_PROCESS_HOST_H_
6 #define MOJO_SHELL_RUNNER_HOST_CHILD_PROCESS_HOST_H_ 6 #define MOJO_SHELL_RUNNER_HOST_CHILD_PROCESS_HOST_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 void ExitNow(int32_t exit_code); 74 void ExitNow(int32_t exit_code);
75 75
76 protected: 76 protected:
77 void DidStart(const ProcessReadyCallback& callback); 77 void DidStart(const ProcessReadyCallback& callback);
78 78
79 private: 79 private:
80 void DoLaunch(); 80 void DoLaunch();
81 81
82 void AppCompleted(int32_t result); 82 void AppCompleted(int32_t result);
83 83
84 // If |true|, the hosted process is neither launched nor owned by this
85 // ChildProcessHost.
86 bool external_process_ = false;
87
84 scoped_refptr<base::TaskRunner> launch_process_runner_; 88 scoped_refptr<base::TaskRunner> launch_process_runner_;
85 NativeRunnerDelegate* delegate_; 89 NativeRunnerDelegate* delegate_;
86 bool start_sandboxed_; 90 bool start_sandboxed_;
87 Identity target_; 91 Identity target_;
88 const base::FilePath app_path_; 92 const base::FilePath app_path_;
89 base::Process child_process_; 93 base::Process child_process_;
90 // Used for the ChildController binding. 94 // Used for the ChildController binding.
91 edk::PlatformChannelPair platform_channel_pair_; 95 edk::PlatformChannelPair platform_channel_pair_;
92 mojom::ChildControllerPtr controller_; 96 mojom::ChildControllerPtr controller_;
93 mojom::ChildController::StartAppCallback on_app_complete_; 97 mojom::ChildController::StartAppCallback on_app_complete_;
(...skipping 11 matching lines...) Expand all
105 109
106 base::WeakPtrFactory<ChildProcessHost> weak_factory_; 110 base::WeakPtrFactory<ChildProcessHost> weak_factory_;
107 111
108 DISALLOW_COPY_AND_ASSIGN(ChildProcessHost); 112 DISALLOW_COPY_AND_ASSIGN(ChildProcessHost);
109 }; 113 };
110 114
111 } // namespace shell 115 } // namespace shell
112 } // namespace mojo 116 } // namespace mojo
113 117
114 #endif // MOJO_SHELL_RUNNER_HOST_CHILD_PROCESS_HOST_H_ 118 #endif // MOJO_SHELL_RUNNER_HOST_CHILD_PROCESS_HOST_H_
OLDNEW
« no previous file with comments | « no previous file | mojo/shell/runner/host/child_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698