Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1753893002: Issue 25827. Don't propose to remove the type of an incomplete variable declaration. (Closed)

Created:
4 years, 9 months ago by scheglov
Modified:
4 years, 9 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Issue 25827. Don't propose to remove the type of an incomplete variable declaration. R=brianwilkerson@google.com BUG= https://github.com/dart-lang/sdk/issues/25827 Committed: https://github.com/dart-lang/sdk/commit/e225e619cdca131512d40a2276b4d1cd8ba437bf

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +5 lines, -0 lines 1 comment Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 9 months ago (2016-03-01 19:39:30 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1753893002/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart File pkg/analysis_server/lib/src/services/correction/assist_internal.dart (right): https://codereview.chromium.org/1753893002/diff/1/pkg/analysis_server/lib/src/services/correction/assist_internal.dart#newcode1454 pkg/analysis_server/lib/src/services/correction/assist_internal.dart:1454: if (firstVariable.name.isSynthetic) { Do we want to do ...
4 years, 9 months ago (2016-03-01 19:50:08 UTC) #2
scheglov
4 years, 9 months ago (2016-03-01 20:20:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e225e619cdca131512d40a2276b4d1cd8ba437bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698