Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

Issue 1753893002: Issue 25827. Don't propose to remove the type of an incomplete variable declaration. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/correction/assist_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/services/correction/assist_internal.dart
diff --git a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart
index a35eeb82b9880b9a8524f12a2cf6ff0a4a30a65c..0fbdee6c9e9fe5ffcfb5002270d46e29c432e994 100644
--- a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart
+++ b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart
@@ -1450,6 +1450,11 @@ class AssistProcessor {
_coverageMarker();
return;
}
+ // ignore if an incomplete variable declaration
+ if (firstVariable.name.isSynthetic) {
Brian Wilkerson 2016/03/01 19:50:08 Do we want to do this only for the first variable,
+ _coverageMarker();
+ return;
+ }
// add edit
Token keyword = declarationList.keyword;
SourceRange typeRange = rangeStartStart(typeNode, firstVariable);
« no previous file with comments | « no previous file | pkg/analysis_server/test/services/correction/assist_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698