[PPAPI][MediaStream] Add browser tests for MediaStreamAudioTrack

[PPAPI][MediaStream] Add browser tests for MediaStreamAudioTrack

BUG=330851
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252755

[Peng, 2014-02-21 19:22:47]

Hi David, I created a new CL. PTAL. Thanks.

[dmichael (off chromium), 2014-02-21 19:30:57]

lgtm, thanks!

https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_strea...
File ppapi/tests/test_media_stream_audio_track.cc (right):

https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_strea...
ppapi/tests/test_media_stream_audio_track.cc:27: "  plugin.postMessage({track:
track});"
nit: It might be clearer to use a different name for the key and the variable,
just for clarity. You might even be able to pass it alone without sticking it in
a dictionary...  that's *supposed* to work, anyway.

https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_strea...
ppapi/tests/test_media_stream_audio_track.cc:33:
"navigator.webkitGetUserMedia(constraints,"
Would it be worthwhile to do something like:
getUserMedia = navigator.getUserMedia || navigator.webkitGetUserMedia;
getUserMedia(constraints, gotStream, function() {});

...so that your test will use the unprefixed one if/when it's available?

https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_strea...
ppapi/tests/test_media_stream_audio_track.cc:112:
ASSERT_EQ(buffer.GetSampleRate(), PP_AUDIOBUFFER_SAMPLERATE_UNKNOWN);
A short comment above this might help. E.g.:
"A recycled buffer should be invalidated."

[Peng, 2014-02-21 20:28:24]

https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_strea...
File ppapi/tests/test_media_stream_audio_track.cc (right):

https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_strea...
ppapi/tests/test_media_stream_audio_track.cc:27: "  plugin.postMessage({track:
track});"
On 2014/02/21 19:30:57, dmichael wrote:
> nit: It might be clearer to use a different name for the key and the variable,
> just for clarity. You might even be able to pass it alone without sticking it
in
> a dictionary...  that's *supposed* to work, anyway.

Done.

https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_strea...
ppapi/tests/test_media_stream_audio_track.cc:33:
"navigator.webkitGetUserMedia(constraints,"
On 2014/02/21 19:30:57, dmichael wrote:
> Would it be worthwhile to do something like:
> getUserMedia = navigator.getUserMedia || navigator.webkitGetUserMedia;
> getUserMedia(constraints, gotStream, function() {});
> 
> ...so that your test will use the unprefixed one if/when it's available?

getUserMedia = ... does not work, have to use navigator.getUserMedia = ...


Done.

https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_strea...
ppapi/tests/test_media_stream_audio_track.cc:112:
ASSERT_EQ(buffer.GetSampleRate(), PP_AUDIOBUFFER_SAMPLERATE_UNKNOWN);
On 2014/02/21 19:30:57, dmichael wrote:
> A short comment above this might help. E.g.:
> "A recycled buffer should be invalidated."

Done.

[Peng, 2014-02-21 20:28:29]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2014-02-21 20:30:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/penghuang@chromium.org/175383003/50001

[commit-bot: I haz the power, 2014-02-21 20:30:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 20:30:26]

Failed to apply patch for chrome/test/ppapi/ppapi_browsertest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/test/ppapi/ppapi_browsertest.cc
  Hunk #1 FAILED at 1648.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/test/ppapi/ppapi_browsertest.cc.rej

Patch:       chrome/test/ppapi/ppapi_browsertest.cc
Index: chrome/test/ppapi/ppapi_browsertest.cc
diff --git a/chrome/test/ppapi/ppapi_browsertest.cc
b/chrome/test/ppapi/ppapi_browsertest.cc
index
fc917a6c4e6ad5c8c70714369d5f2cc9aabf177c..74c6b8ee424004006a47f386ac2565d7a9ea3c28
100644
--- a/chrome/test/ppapi/ppapi_browsertest.cc
+++ b/chrome/test/ppapi/ppapi_browsertest.cc
@@ -1648,6 +1648,9 @@ IN_PROC_BROWSER_TEST_F(OutOfProcessPPAPITest,
MAYBE_FlashMessageLoop) {
           LIST_TEST(FlashMessageLoop_RunWithoutQuit));
 }
 
+TEST_PPAPI_OUT_OF_PROCESS(MediaStreamAudioTrack)
+TEST_PPAPI_NACL(MediaStreamAudioTrack)
+
 TEST_PPAPI_OUT_OF_PROCESS(MediaStreamVideoTrack)
 TEST_PPAPI_NACL(MediaStreamVideoTrack)

[Peng, 2014-02-21 20:44:51]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2014-02-21 20:45:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/penghuang@chromium.org/175383003/160001

[commit-bot: I haz the power, 2014-02-21 21:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 21:40:29]

Retried try job too often on win_rel for step(s) content_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Peng, 2014-02-21 21:49:25]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2014-02-21 21:50:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/penghuang@chromium.org/175383003/380001

[commit-bot: I haz the power, 2014-02-22 01:23:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/penghuang@chromium.org/175383003/380001

[commit-bot: I haz the power, 2014-02-22 07:42:18]

Change committed as 252755