Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 175383003: [PPAPI][MediaStream] Add browser tests for MediaStreamAudioTrack (Closed)

Created:
6 years, 10 months ago by Peng
Modified:
6 years, 10 months ago
CC:
chromium-reviews, kmixter1
Base URL:
https://chromium.googlesource.com/chromium/src.git@browser_test
Visibility:
Public.

Description

[PPAPI][MediaStream] Add browser tests for MediaStreamAudioTrack BUG=330851 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252755

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fix review issues #

Patch Set 3 : Update #

Patch Set 4 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -0 lines) Patch
chrome/test/ppapi/ppapi_browsertest.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
ppapi/ppapi_sources.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
ppapi/tests/test_media_stream_audio_track.h View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
ppapi/tests/test_media_stream_audio_track.cc View 1 2 3 1 chunk +123 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Peng
Hi David, I created a new CL. PTAL. Thanks.
6 years, 10 months ago (2014-02-21 19:22:47 UTC) #1
dmichael (off chromium)
lgtm, thanks! https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_stream_audio_track.cc File ppapi/tests/test_media_stream_audio_track.cc (right): https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_stream_audio_track.cc#newcode27 ppapi/tests/test_media_stream_audio_track.cc:27: " plugin.postMessage({track: track});" nit: It might be ...
6 years, 10 months ago (2014-02-21 19:30:57 UTC) #2
Peng
https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_stream_audio_track.cc File ppapi/tests/test_media_stream_audio_track.cc (right): https://codereview.chromium.org/175383003/diff/1/ppapi/tests/test_media_stream_audio_track.cc#newcode27 ppapi/tests/test_media_stream_audio_track.cc:27: " plugin.postMessage({track: track});" On 2014/02/21 19:30:57, dmichael wrote: > ...
6 years, 10 months ago (2014-02-21 20:28:24 UTC) #3
Peng
The CQ bit was checked by penghuang@chromium.org
6 years, 10 months ago (2014-02-21 20:28:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/175383003/50001
6 years, 10 months ago (2014-02-21 20:30:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 20:30:23 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/test/ppapi/ppapi_browsertest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-21 20:30:26 UTC) #7
Peng
The CQ bit was checked by penghuang@chromium.org
6 years, 10 months ago (2014-02-21 20:44:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/175383003/160001
6 years, 10 months ago (2014-02-21 20:45:57 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 21:40:28 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268021
6 years, 10 months ago (2014-02-21 21:40:29 UTC) #11
Peng
The CQ bit was checked by penghuang@chromium.org
6 years, 10 months ago (2014-02-21 21:49:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/175383003/380001
6 years, 10 months ago (2014-02-21 21:50:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/penghuang@chromium.org/175383003/380001
6 years, 10 months ago (2014-02-22 01:23:37 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-22 07:42:18 UTC) #15
Message was sent while issue was closed.
Change committed as 252755

Powered by Google App Engine
This is Rietveld 408576698