[PPAPI][MediaStream] Add browser tests for MediaStreamAudioTrack

ppapi/tests/test_media_stream_audio_track.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+//
+// Tests PPB_MediaStreamAudioTrack interface.
+
+#include "ppapi/tests/test_media_stream_audio_track.h"
+
+#include "ppapi/c/private/ppb_testing_private.h"
+#include "ppapi/cpp/audio_buffer.h"
+#include "ppapi/cpp/completion_callback.h"
+#include "ppapi/cpp/instance.h"
+#include "ppapi/cpp/var.h"
+#include "ppapi/tests/test_utils.h"
+#include "ppapi/tests/testing_instance.h"
+
+REGISTER_TEST_CASE(MediaStreamAudioTrack);
+
+namespace {
+
+const int32_t kTimes = 3;
+const char kJSCode[] =
+    "function gotStream(stream) {"
+    "  test_stream = stream;"
+    "  var track = stream.getAudioTracks()[0];"
+    "  var plugin = document.getElementById('plugin');"
+    "  plugin.postMessage({track: track});"

[dmichael (off chromium), 2014/02/21 19:30:57]

nit: It might be clearer to use a different name for the key and the variable,
just for clarity. You might even be able to pass it alone without sticking it in
a dictionary...  that's *supposed* to work, anyway.

[Peng, 2014/02/21 20:28:24]

Done.

+    "}"
+    "var constraints = {"
+    "  audio: true,"
+    "  video: false,"
+    "};"
+    "navigator.webkitGetUserMedia(constraints,"

[dmichael (off chromium), 2014/02/21 19:30:57]

Would it be worthwhile to do something like:
getUserMedia = navigator.getUserMedia || navigator.webkitGetUserMedia;
getUserMedia(constraints, gotStream, function() {});

...so that your test will use the unprefixed one if/when it's available?

[Peng, 2014/02/21 20:28:24]

getUserMedia = ... does not work, have to use navigator.getUserMedia = ...


Done.

+    "    gotStream, function() {});";
+}
+
+TestMediaStreamAudioTrack::TestMediaStreamAudioTrack(TestingInstance* instance)
+    : TestCase(instance),
+      event_(instance_->pp_instance()) {
+}
+
+bool TestMediaStreamAudioTrack::Init() {
+  return true;
+}
+
+TestMediaStreamAudioTrack::~TestMediaStreamAudioTrack() {
+}
+
+void TestMediaStreamAudioTrack::RunTests(const std::string& filter) {
+  RUN_TEST(Create, filter);
+  RUN_TEST(GetBuffer, filter);
+}
+
+void TestMediaStreamAudioTrack::HandleMessage(const pp::Var& message) {
+  if (message.is_dictionary()) {
+    pp::Var var_track = pp::VarDictionary(message).Get("track");
+    if (var_track.is_resource()) {
+      audio_track_ = pp::MediaStreamAudioTrack(var_track.AsResource());
+    }
+  }
+  event_.Signal();
+}
+
+std::string TestMediaStreamAudioTrack::TestCreate() {
+  // Create a track.
+  instance_->EvalScript(kJSCode);
+  event_.Wait();
+  event_.Reset();
+
+  ASSERT_FALSE(audio_track_.is_null());
+  ASSERT_FALSE(audio_track_.HasEnded());
+  ASSERT_FALSE(audio_track_.GetId().empty());
+
+  // Close the track.
+  audio_track_.Close();
+  ASSERT_TRUE(audio_track_.HasEnded());
+  audio_track_ = pp::MediaStreamAudioTrack();
+  PASS();
+}
+
+std::string TestMediaStreamAudioTrack::TestGetBuffer() {
+  // Create a track.
+  instance_->EvalScript(kJSCode);
+  event_.Wait();
+  event_.Reset();
+
+  ASSERT_FALSE(audio_track_.is_null());
+  ASSERT_FALSE(audio_track_.HasEnded());
+  ASSERT_FALSE(audio_track_.GetId().empty());
+
+  PP_TimeDelta timestamp = 0.0;
+
+  // Get |kTimes| buffers.
+  for (int i = 0; i < kTimes; ++i) {
+    TestCompletionCallbackWithOutput<pp::AudioBuffer> cc(
+        instance_->pp_instance(), false);
+    cc.WaitForResult(audio_track_.GetBuffer(cc.GetCallback()));
+    ASSERT_EQ(PP_OK, cc.result());
+    pp::AudioBuffer buffer = cc.output();
+    ASSERT_FALSE(buffer.is_null());
+    ASSERT_EQ(buffer.GetSampleRate(), PP_AUDIOBUFFER_SAMPLERATE_44100);
+    ASSERT_EQ(buffer.GetSampleSize(), PP_AUDIOBUFFER_SAMPLESIZE_16_BITS);
+
+    ASSERT_GE(buffer.GetTimestamp(), timestamp);
+    timestamp = buffer.GetTimestamp();
+
+    ASSERT_GT(buffer.GetDataBufferSize(), 0U);
+    ASSERT_TRUE(buffer.GetDataBuffer() != NULL);
+
+    audio_track_.RecycleBuffer(buffer);
+
+    ASSERT_EQ(buffer.GetSampleRate(), PP_AUDIOBUFFER_SAMPLERATE_UNKNOWN);

[dmichael (off chromium), 2014/02/21 19:30:57]

A short comment above this might help. E.g.:
"A recycled buffer should be invalidated."

[Peng, 2014/02/21 20:28:24]

Done.

+    ASSERT_EQ(buffer.GetSampleSize(), PP_AUDIOBUFFER_SAMPLESIZE_UNKNOWN);
+    ASSERT_EQ(buffer.GetDataBufferSize(), 0U);
+    ASSERT_TRUE(buffer.GetDataBuffer() == NULL);
+  }
+
+  // Close the track.
+  audio_track_.Close();
+  ASSERT_TRUE(audio_track_.HasEnded());
+  audio_track_ = pp::MediaStreamAudioTrack();
+  PASS();
+}