Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1753773002: Omit DefaultBrowserHandler from CrOS. (Closed)

Created:
4 years, 9 months ago by grt (UTC plus 2)
Modified:
4 years, 9 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Omit DefaultBrowserHandler from CrOS. basic_page.html already conditionally includes the .html for non-CrOS only, so there's no need for the backing C++ on CrOS. BUG=536295 R=dschuyler@chromium.org Committed: https://crrev.com/74e439e20d46cec9da36c944cf3a015bb6b166f7 Cr-Commit-Position: refs/heads/master@{#378465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 4 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
grt (UTC plus 2)
PTAL, thanks!
4 years, 9 months ago (2016-03-01 15:35:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753773002/1
4 years, 9 months ago (2016-03-01 15:36:05 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-01 16:19:32 UTC) #5
dschuyler
lgtm
4 years, 9 months ago (2016-03-01 17:05:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1753773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1753773002/1
4 years, 9 months ago (2016-03-01 17:21:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 17:28:19 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 17:29:33 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74e439e20d46cec9da36c944cf3a015bb6b166f7
Cr-Commit-Position: refs/heads/master@{#378465}

Powered by Google App Engine
This is Rietveld 408576698