Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(885)

Side by Side Diff: chrome/browser/ui/webui/settings/md_settings_ui.cc

Issue 1753773002: Omit DefaultBrowserHandler from CrOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/md_settings_ui.h" 5 #include "chrome/browser/ui/webui/settings/md_settings_ui.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/metrics/histogram_macros.h" 11 #include "base/metrics/histogram_macros.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/browser/ui/webui/settings/appearance_handler.h" 13 #include "chrome/browser/ui/webui/settings/appearance_handler.h"
14 #include "chrome/browser/ui/webui/settings/downloads_handler.h" 14 #include "chrome/browser/ui/webui/settings/downloads_handler.h"
15 #include "chrome/browser/ui/webui/settings/font_handler.h" 15 #include "chrome/browser/ui/webui/settings/font_handler.h"
16 #include "chrome/browser/ui/webui/settings/languages_handler.h" 16 #include "chrome/browser/ui/webui/settings/languages_handler.h"
17 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h" 17 #include "chrome/browser/ui/webui/settings/md_settings_localized_strings_provide r.h"
18 #include "chrome/browser/ui/webui/settings/people_handler.h" 18 #include "chrome/browser/ui/webui/settings/people_handler.h"
19 #include "chrome/browser/ui/webui/settings/reset_settings_handler.h" 19 #include "chrome/browser/ui/webui/settings/reset_settings_handler.h"
20 #include "chrome/browser/ui/webui/settings/search_engines_handler.h" 20 #include "chrome/browser/ui/webui/settings/search_engines_handler.h"
21 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h" 21 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h"
22 #include "chrome/browser/ui/webui/settings/settings_default_browser_handler.h"
23 #include "chrome/browser/ui/webui/settings/settings_startup_pages_handler.h" 22 #include "chrome/browser/ui/webui/settings/settings_startup_pages_handler.h"
24 #include "chrome/browser/ui/webui/settings/site_settings_handler.h" 23 #include "chrome/browser/ui/webui/settings/site_settings_handler.h"
25 #include "chrome/common/url_constants.h" 24 #include "chrome/common/url_constants.h"
26 #include "content/public/browser/web_contents.h" 25 #include "content/public/browser/web_contents.h"
27 #include "content/public/browser/web_ui.h" 26 #include "content/public/browser/web_ui.h"
28 #include "content/public/browser/web_ui_data_source.h" 27 #include "content/public/browser/web_ui_data_source.h"
29 #include "grit/settings_resources.h" 28 #include "grit/settings_resources.h"
30 #include "grit/settings_resources_map.h" 29 #include "grit/settings_resources_map.h"
31 30
32 #if defined(OS_CHROMEOS) 31 #if defined(OS_CHROMEOS)
33 #include "chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h" 32 #include "chrome/browser/ui/webui/settings/chromeos/change_picture_handler.h"
34 #else // !defined(OS_CHROMEOS) 33 #else // !defined(OS_CHROMEOS)
34 #include "chrome/browser/ui/webui/settings/settings_default_browser_handler.h"
35 #include "chrome/browser/ui/webui/settings/settings_manage_profile_handler.h" 35 #include "chrome/browser/ui/webui/settings/settings_manage_profile_handler.h"
36 #endif // defined(OS_CHROMEOS) 36 #endif // defined(OS_CHROMEOS)
37 37
38 namespace settings { 38 namespace settings {
39 39
40 SettingsPageUIHandler::SettingsPageUIHandler() { 40 SettingsPageUIHandler::SettingsPageUIHandler() {
41 } 41 }
42 42
43 SettingsPageUIHandler::~SettingsPageUIHandler() { 43 SettingsPageUIHandler::~SettingsPageUIHandler() {
44 } 44 }
45 45
46 void SettingsPageUIHandler::CallJavascriptCallback( 46 void SettingsPageUIHandler::CallJavascriptCallback(
47 const base::Value& callback_id, const base::Value& response) { 47 const base::Value& callback_id, const base::Value& response) {
48 // cr.webUIResponse is a global JS function exposed from cr.js. 48 // cr.webUIResponse is a global JS function exposed from cr.js.
49 web_ui()->CallJavascriptFunction("cr.webUIResponse", callback_id, response); 49 web_ui()->CallJavascriptFunction("cr.webUIResponse", callback_id, response);
50 } 50 }
51 51
52 MdSettingsUI::MdSettingsUI(content::WebUI* web_ui) 52 MdSettingsUI::MdSettingsUI(content::WebUI* web_ui)
53 : content::WebUIController(web_ui), 53 : content::WebUIController(web_ui),
54 WebContentsObserver(web_ui->GetWebContents()) { 54 WebContentsObserver(web_ui->GetWebContents()) {
55 Profile* profile = Profile::FromWebUI(web_ui); 55 Profile* profile = Profile::FromWebUI(web_ui);
56 AddSettingsPageUIHandler(new AppearanceHandler(web_ui)); 56 AddSettingsPageUIHandler(new AppearanceHandler(web_ui));
57 AddSettingsPageUIHandler(new ClearBrowsingDataHandler(web_ui)); 57 AddSettingsPageUIHandler(new ClearBrowsingDataHandler(web_ui));
58 AddSettingsPageUIHandler(new DefaultBrowserHandler(web_ui));
59 AddSettingsPageUIHandler(new DownloadsHandler()); 58 AddSettingsPageUIHandler(new DownloadsHandler());
60 AddSettingsPageUIHandler(new FontHandler(web_ui)); 59 AddSettingsPageUIHandler(new FontHandler(web_ui));
61 AddSettingsPageUIHandler(new LanguagesHandler(web_ui)); 60 AddSettingsPageUIHandler(new LanguagesHandler(web_ui));
62 AddSettingsPageUIHandler(new PeopleHandler(profile)); 61 AddSettingsPageUIHandler(new PeopleHandler(profile));
63 AddSettingsPageUIHandler(new SearchEnginesHandler(profile)); 62 AddSettingsPageUIHandler(new SearchEnginesHandler(profile));
64 AddSettingsPageUIHandler(new SiteSettingsHandler(profile)); 63 AddSettingsPageUIHandler(new SiteSettingsHandler(profile));
65 AddSettingsPageUIHandler(new StartupPagesHandler(web_ui)); 64 AddSettingsPageUIHandler(new StartupPagesHandler(web_ui));
66 65
67 #if defined(OS_CHROMEOS) 66 #if defined(OS_CHROMEOS)
68 AddSettingsPageUIHandler(new chromeos::settings::ChangePictureHandler()); 67 AddSettingsPageUIHandler(new chromeos::settings::ChangePictureHandler());
69 #else 68 #else
69 AddSettingsPageUIHandler(new DefaultBrowserHandler(web_ui));
70 AddSettingsPageUIHandler(new ManageProfileHandler(profile)); 70 AddSettingsPageUIHandler(new ManageProfileHandler(profile));
71 #endif 71 #endif
72 72
73 content::WebUIDataSource* html_source = 73 content::WebUIDataSource* html_source =
74 content::WebUIDataSource::Create(chrome::kChromeUIMdSettingsHost); 74 content::WebUIDataSource::Create(chrome::kChromeUIMdSettingsHost);
75 75
76 AddSettingsPageUIHandler(ResetSettingsHandler::Create(html_source, profile)); 76 AddSettingsPageUIHandler(ResetSettingsHandler::Create(html_source, profile));
77 77
78 // Add all settings resources. 78 // Add all settings resources.
79 for (size_t i = 0; i < kSettingsResourcesSize; ++i) { 79 for (size_t i = 0; i < kSettingsResourcesSize; ++i) {
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 UMA_HISTOGRAM_TIMES("Settings.LoadDocumentTime.MD", 112 UMA_HISTOGRAM_TIMES("Settings.LoadDocumentTime.MD",
113 base::Time::Now() - load_start_time_); 113 base::Time::Now() - load_start_time_);
114 } 114 }
115 115
116 void MdSettingsUI::DocumentOnLoadCompletedInMainFrame() { 116 void MdSettingsUI::DocumentOnLoadCompletedInMainFrame() {
117 UMA_HISTOGRAM_TIMES("Settings.LoadCompletedTime.MD", 117 UMA_HISTOGRAM_TIMES("Settings.LoadCompletedTime.MD",
118 base::Time::Now() - load_start_time_); 118 base::Time::Now() - load_start_time_);
119 } 119 }
120 120
121 } // namespace settings 121 } // namespace settings
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698