third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.cpp - Issue 1753703005: Simplify TypingCommand::insertText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.cpp

Issue 1753703005: Simplify TypingCommand::insertText (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.h ('k') | third_party/WebKit/Source/core/editing/commands/TypingCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.cpp b/third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.cpp

index 25b37f0bef445b3562348aa6399aab05c520f6e0..c1fc6cddc3499432c69aa17331bed3f4f46b1886 100644

--- a/third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/TextInsertionBaseCommand.cpp

@@ -39,20 +39,6 @@ TextInsertionBaseCommand::TextInsertionBaseCommand(Document& document)

{

}

-void TextInsertionBaseCommand::applyTextInsertionCommand(LocalFrame* frame, PassRefPtrWillBeRawPtr<TextInsertionBaseCommand> command, const VisibleSelection& selectionForInsertion, const VisibleSelection& endingSelection)

- bool changeSelection = !equalSelectionsInDOMTree(selectionForInsertion, endingSelection);

- if (changeSelection) {

- command->setStartingSelection(selectionForInsertion);

- command->setEndingSelection(selectionForInsertion);

- }

- command->apply();

- if (changeSelection) {

- command->setEndingSelection(endingSelection);

- frame->selection().setSelection(endingSelection);

- }

String dispatchBeforeTextInsertedEvent(const String& text, const VisibleSelection& selectionForInsertion, bool insertionIsForUpdatingComposition)

{

if (insertionIsForUpdatingComposition)