runtime/vm/code_descriptors.cc - Issue 1753053003: When a catch is unreachable, use the canonical empty array instead of null as its type array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/code_descriptors.cc

Issue 1753053003: When a catch is unreachable, use the canonical empty array instead of null as its type array. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/code_descriptors.cc

diff --git a/runtime/vm/code_descriptors.cc b/runtime/vm/code_descriptors.cc

index dad76d97e0179cb0b70c971d282fcc663011ce2a..b7b432671a1deda24cde41a6028e8fe92e613130 100644

--- a/runtime/vm/code_descriptors.cc

+++ b/runtime/vm/code_descriptors.cc

@@ -124,7 +124,7 @@ RawExceptionHandlers* ExceptionHandlerList::FinalizeExceptionHandlers(

list_[i].pc_offset,

list_[i].needs_stacktrace,

has_catch_all);

- handlers.SetHandledTypes(i, Array::null_array());

+ handlers.SetHandledTypes(i, Array::empty_array());

} else {

const bool has_catch_all = ContainsDynamic(*list_[i].handler_types);

handlers.SetHandlerInfo(i,

« no previous file with comments | « no previous file | runtime/vm/object.cc » ('j') | no next file with comments »