runtime/vm/object.cc - Issue 1753053003: When a catch is unreachable, use the canonical empty array instead of null as its type array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 1753053003: When a catch is unreachable, use the canonical empty array instead of null as its type array. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 300070befde0c5323671432aae90db733c4d2115..0c959cd387390bde40cf85246db640950a0f51b3 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -11666,6 +11666,7 @@ bool ExceptionHandlers::HasCatchAll(intptr_t try_index) const {

void ExceptionHandlers::SetHandledTypes(intptr_t try_index,

const Array& handled_types) const {

ASSERT((try_index >= 0) && (try_index < num_entries()));

+ ASSERT(!handled_types.IsNull());

const Array& handled_types_data =

Array::Handle(raw_ptr()->handled_types_data_);

handled_types_data.SetAt(try_index, handled_types);

« no previous file with comments | « runtime/vm/code_descriptors.cc ('k') | runtime/vm/precompiler.cc » ('j') | no next file with comments »