Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1753053003: When a catch is unreachable, use the canonical empty array instead of null as its type array. (Closed)

Created:
4 years, 9 months ago by rmacnak
Modified:
4 years, 9 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When a catch is unreachable, use the canonical empty array instead of null as its type array. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/48af897a3ec8d58b90f8b245acc7cfb81032d70e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M runtime/vm/code_descriptors.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 9 months ago (2016-03-02 01:52:59 UTC) #2
Ivan Posva
LGTM -ip
4 years, 9 months ago (2016-03-02 04:57:14 UTC) #3
rmacnak
4 years, 9 months ago (2016-03-02 17:46:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
48af897a3ec8d58b90f8b245acc7cfb81032d70e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698