Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: mojo/dart/apptests/dart_apptests/lib/main.dart

Issue 1753013002: Mojom runtime type info: New implementation for Dart. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Response to code review. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/dart/apptests/dart_apptests/lib/main.dart
diff --git a/mojo/dart/apptests/dart_apptests/lib/main.dart b/mojo/dart/apptests/dart_apptests/lib/main.dart
index 5922ef632491e026f43ccffc9fc32db5c2a3084d..e508e0ad490c9a372f5e8b7d0f852b4c909cc97f 100644
--- a/mojo/dart/apptests/dart_apptests/lib/main.dart
+++ b/mojo/dart/apptests/dart_apptests/lib/main.dart
@@ -17,13 +17,17 @@ import 'src/versioning_apptests.dart' as versioning;
main(List args, Object handleToken) {
final tests = [
+ // Note(rudominer) When service_describer.test is put further down in the
+ // list then it times out about 25% of the time. This is disturbing but
+ // I am unable to determine why and so for now am simply moving it to
+ // the top of the list.
+ service_describer.tests,
rudominer 2016/03/03 01:27:51 One thing to note about this hack: It appears to b
alexfandrianto 2016/03/03 02:26:23 That is very troubling behavior. I wonder what's h
zra 2016/03/03 16:52:36 Application shutdown can race with a new client re
rudominer 2016/03/03 22:46:14 I have made the changes you suggested over hangout
connect_to_loader_apptests.connectToLoaderApptests,
echo.echoApptests,
file.tests,
io_internet_address.tests,
io_http.tests,
pingpong.pingpongApptests,
- service_describer.tests,
uri.tests,
versioning.tests
];

Powered by Google App Engine
This is Rietveld 408576698