Mojom runtime type info: New implementation for Dart.

mojo/dart/apptests/dart_apptests/lib/main.dart

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 import 'dart:async';
 import 'package:mojo_apptest/apptest.dart';
 
 import 'src/connect_to_loader_apptests.dart' as connect_to_loader_apptests;
 import 'src/echo_apptests.dart' as echo;
 import 'src/file_apptests.dart' as file;
 import 'src/io_http_apptests.dart' as io_http;
 import 'src/io_internet_address_apptests.dart' as io_internet_address;
 import 'src/pingpong_apptests.dart' as pingpong;
 import 'src/service_describer_apptests.dart' as service_describer;
 import 'src/uri_apptests.dart' as uri;
 import 'src/versioning_apptests.dart' as versioning;
 
 main(List args, Object handleToken) {
   final tests = [
+    // Note(rudominer) When service_describer.test is put further down in the
+    // list then it times out about 25% of the time. This is disturbing but
+    // I am unable to determine why and so for now am simply moving it to
+    // the top of the list.
+    service_describer.tests,

[rudominer, 2016/03/03 01:27:51]

One thing to note about this hack: It appears to be due to my change to the
*test* not my change to the code. In a clean client I can make the same change
to the test and reproduce the intermittent time-out. So while we should get to
the bottom of this, it does not appear to be caused by my changes. The change to
the test I made is to query PingPongService instead of EchoService. Also note
that I found other ways of eliminating the flakiness besides moving this line to
the top of the list. Commenting out either
- both connect_to_loader_apptests and echo
or
- file

Also seemed to work. So there is some race condition somewhere and some
complicated interaction between multiple apptests.

[alexfandrianto, 2016/03/03 02:26:23]

That is very troubling behavior. I wonder what's happening. Is there an issue to
track this?

[zra, 2016/03/03 16:52:36]

Application shutdown can race with a new client requesting a service from the
application that is shutting down. I bet that's what you're hitting here. I've
made a suggestion in the test to help investigate, but if that doesn't shed any
light on things, we can land this CL and file a bug assigned to me.

[rudominer, 2016/03/03 22:46:14]

I have made the changes you suggested over hangouts but the behavior has not
changed and I don't see any more diagnostic info.

     connect_to_loader_apptests.connectToLoaderApptests,
     echo.echoApptests,
     file.tests,
     io_internet_address.tests,
     io_http.tests,
     pingpong.pingpongApptests,
-    service_describer.tests,
     uri.tests,
     versioning.tests
   ];
   runAppTests(handleToken, tests);
 }