Mojom runtime type info: New implementation for Dart.

mojo/dart/apptests/dart_apptests/lib/src/service_describer_apptests.dart

Index: mojo/dart/apptests/dart_apptests/lib/src/service_describer_apptests.dart
diff --git a/mojo/dart/apptests/dart_apptests/lib/src/service_describer_apptests.dart b/mojo/dart/apptests/dart_apptests/lib/src/service_describer_apptests.dart
index ccafe587a1ebc3b73dfd978727c9a250073a79f9..7eb5a4b6e3131c65f3650e13dd58652c14507be1 100644
--- a/mojo/dart/apptests/dart_apptests/lib/src/service_describer_apptests.dart
+++ b/mojo/dart/apptests/dart_apptests/lib/src/service_describer_apptests.dart
@@ -48,14 +48,6 @@ tests(Application application, String url) {
       mojom_types.MojomInterface b = ed.getTopLevelInterface(identity);
       _compare(a, b);
 
-      String interfaceID = "echo_service_EchoService__";
-      mojom_types.MojomInterface c =
-          (await sd.getTypeDefinition(interfaceID)).type.interfaceType;
-      mojom_types.MojomInterface d =
-          ed.getTypeDefinition(interfaceID, identity).interfaceType;
-      _compare(a, c);
-      _compare(c, d);

[alexfandrianto, 2016/03/02 05:27:12]

Does this part of the test need to be removed? If possible, I'd like to keep it
so that we can verify that getTypeDefinition is implemented correctly.

If the problem is the type key, we can reuse the computeTypeKey function (and
TODO) you wrote for the embedder test.

+// computeTypeKey encapsulates the algorithm for computing the type key
+// of a type given its fully-qualified name.
+//
+// TODO(rudominer) Delete this when we add accessors for Mojom types
+// in the Dart bindings.
+String computeTypeKey(String fullyQualifiedName) {
+  return "TYPE_KEY:" + fullyQualifiedName;
+}
+

[rudominer, 2016/03/03 01:09:36]

OK here is what I did: I switched this test to query the PingPongService instead
of the EchoService because the PingPongService uses more than one Mojom type.
Now we can test using getTypeDefinition() the way it is supposed to be used.

-
       // Check that the mojom type definitions match between mappings.
       // For simplicity, check in a shallow manner.
       var actualDescriptions = (await sd.getAllTypeDefinitions()).definitions;